Save and Preview buttons are set wrong when saved form is loaded [#308239]

Recreate:
1. Start creating new content for a node type with autosave turned on.
2. Wait for the autosave handler to save the form.
3. Reload the page.
4. In the status message which reads "This form was autosaved...", click View.

The Save and Preview buttons will now read: "Save,Preview" and "Save,Preview".

This is because Drupal's #node-form has two submit buttons named "op", and .formHash() returns { ..., op: "Save,Preview", ...}. When this is reloaded the buttons are both set to "Save,Preview".

My question is where is the correct place to correct this? Should it be in the form markup? Or should autosave simply ignore the values in the submit buttons?

I propose something like this:

autosaved_form = $('#node-form').formHash();
delete autosaved_form.serialized.op;

This will leave alone the values for the form elements which are named 'op'.

Comment	File	Size	Author
#9	autosave-6.x-1.1-applied-308238-3.tar.gz	14.54 KB	Boobaa
#3	autosave.js_.patch	3.68 KB	darren.ferguson
#3	autosave.module.patch	1.26 KB	darren.ferguson

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

einsicht CreditAttribution: einsicht commented 14 September 2008 at 21:06

I noticed this issue also.

Comment #2

darren.ferguson CreditAttribution: darren.ferguson commented 19 September 2008 at 14:24

Yes looking into this issue, since i noticed it also. Also certain pieces need to be removed from the hash also like the form token.

Comment #3

darren.ferguson CreditAttribution: darren.ferguson commented 19 September 2008 at 15:27

File	Size
autosave.module.patch	1.26 KB
autosave.js_.patch	3.68 KB

Added the capability to decide what you wish to not serialize in the autosave form. This is an administration function for the module and the administrator can provide a list seperated by "|" in order to determine the form fields that they do not wish to save.

The attached patches are against the d6-x-dev version.

Comment #4

darren.ferguson CreditAttribution: darren.ferguson commented 19 September 2008 at 15:35

Status:

Active

» Fixed

The patch above should fix this issue.

Comment #5

geodaniel CreditAttribution: geodaniel commented 19 September 2008 at 15:38

Status:

Fixed

» Needs review

This needs review and committing before it goes to the 'fixed' state :)

Comment #6

Babalu CreditAttribution: Babalu commented 23 September 2008 at 08:47

thx

Comment #7

kenorb CreditAttribution: kenorb commented 20 January 2009 at 13:57

I've applied this patch manually, but it's still not working or I missed something.
Can somebody upload the full patched gzip's, then I can test it.

Comment #8

Jody Lynn

she/her

English

CreditAttribution: Jody Lynn commented 11 February 2009 at 22:39

Comment #9

Boobaa

he/him

CreditAttribution: Boobaa commented 21 May 2009 at 11:11

File	Size
autosave-6.x-1.1-applied-308238-3.tar.gz	14.54 KB

Here is the 1.1 version of the module, with the patches in #3 applied (by hand, since they don't apply out of the box to this version); otherwise it is untouched, but tested and proven to be working fine for now.

Anyway, I'm interested in a release with the above fixes.