Closed (fixed)
Project:
Drupal 7 to Modern Drupal Module Upgrader
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2019 at 17:27 UTC
Updated:
23 Nov 2020 at 14:38 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
andypostComment #3
webchickComment #4
andypostHere's a patch
Comment #5
gábor hojtsy@andypost: is that only there is needed?
Comment #6
solideogloria commentedYep. Works for me with Drush 10.2.2.
Comment #7
gisleIt works out of the box for me without this patch:
drush 10.3.5
drupal 8.9.7
Comment #8
solideogloria commentedI can't remember if the patch was necessary for it to work in Drush 10.2 or not (I think it was?), but I just tested it again in Drush 10.3.4, and it does indeed work without the patch.
Comment #9
jcnventuraFrom https://www.drush.org/commands/#specifying-the-services-file:
RTBC++
Comment #11
jcnventuraComment #13
joseph.olstadThis change may have broken our tests, there was a commit made November 4th that broke our tests. see the following issues and links:
4 Nov 2020 at 04:27 EST
PHP 7.1 & MySQL 5.5, D8.9 Composer require failure
18 Sep 2019 at 10:45 EDT
PHP 7.1 & MySQL 5.5, D8.7 242 pass
Other changes that were made November 4th that may have caused this:
#3165948: License "GPL-2.0+" is a deprecated SPDX license identifier, use "GPL-2.0-or-later" instead
#2598934: Hook_Array warning on upgrade attempt
#3081813: Add drush 10 support
Comment #14
joseph.olstadfix automated tests, broken with changes made November 4th 2020
#3183927: Fix automated tests, broken since November 4th 2020
Proposed resolution / Remaining Tasks
make a patch that reverts all changes made november 4th and see if it fixes the tests.
Comment #15
solideogloria commentedThe tests appear to be passing again.