Problem/Motivation

Drush 9 support just commited in #2949601: Drush 9 compatibility
But drush 10 is released https://github.com/drush-ops/drush/releases/tag/10.0.0

Proposed resolution

Check code compatibility with drush 10 and add composer.json extra section "drush.services.yml": "^9 || ^10"
See #3071228: Drush 10 compat

Remaining tasks

check compatibility
create patch
test both versions

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

CommentFileSizeAuthor
#4 3081813-4.patch329 bytesandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

Assigned: andypost » Unassigned
webchick’s picture

Priority: Normal » Major
andypost’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new329 bytes

Here's a patch

gábor hojtsy’s picture

@andypost: is that only there is needed?

solideogloria’s picture

Status: Needs review » Reviewed & tested by the community

Yep. Works for me with Drush 10.2.2.

gisle’s picture

It works out of the box for me without this patch:

drush 10.3.5
drupal 8.9.7

solideogloria’s picture

I can't remember if the patch was necessary for it to work in Drush 10.2 or not (I think it was?), but I just tested it again in Drush 10.3.4, and it does indeed work without the patch.

jcnventura’s picture

From https://www.drush.org/commands/#specifying-the-services-file:

In Drush 10, however, the services section must exist, and must name the services file to be used. If a future Drush extension is written such that it only works with Drush 10 and later, then its entry would read "drush.services.yml": "^10", and Drush 9 would not load the extension's commands. It is all the same recommended that Drush 9 extensions explicitly declare their services file with an appropriate version constraint.

RTBC++

  • jcnventura committed 4bdcbb5 on 8.x-1.x authored by andypost
    Issue #3081813 by andypost, solideogloria, gisle, jcnventura: Add drush...
jcnventura’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

This change may have broken our tests, there was a commit made November 4th that broke our tests. see the following issues and links:


4 Nov 2020 at 04:27 EST

PHP 7.1 & MySQL 5.5, D8.9 Composer require failure

18 Sep 2019 at 10:45 EDT

PHP 7.1 & MySQL 5.5, D8.7 242 pass

Other changes that were made November 4th that may have caused this:

#3165948: License "GPL-2.0+" is a deprecated SPDX license identifier, use "GPL-2.0-or-later" instead

#2598934: Hook_Array warning on upgrade attempt

#3081813: Add drush 10 support

joseph.olstad’s picture

fix automated tests, broken with changes made November 4th 2020

#3183927: Fix automated tests, broken since November 4th 2020

Proposed resolution / Remaining Tasks

make a patch that reverts all changes made november 4th and see if it fixes the tests.

solideogloria’s picture

The tests appear to be passing again.