Implement a Drush command to clean obsolete composite entities

Quite easy now that the service is there. Thanks for that.

The patch in #4 worked well for us.

1. +++ b/composer.json
   @@ -0,0 +1,12 @@
   +{
   +    "name": "drupal/entity_reference_revisions",
   +    "description": "Adds a Entity Reference field type with revision support.",
   +    "type": "drupal-module",
   +    "extra": {
   +        "drush": {
   +            "services": {
   +                "drush.services.yml": "^9 || ^10"
   +            }
   +        }
   +    }
   

   I suppose the addition of the composer.json file somehow breaks dev dependencies, even though they seem to be still added?

   Lets add diff as a require-dev dependency and remove the test_dependencies key in .info.yml to see if that helps.

2. +++ b/src/EntityReferenceRevisionsOrphanPurger.php
   @@ -138,10 +138,10 @@ class EntityReferenceRevisionsOrphanPurger {
       *   The entity type id, for example 'paragraph'.
   -   * @param array $context
   +   * @param $context
       *   The context array.
       */
   -  public function deleteOrphansBatchOperation($entity_type_id, array &$context) {
   +  public function deleteOrphansBatchOperation($entity_type_id, &$context) {
        $composite_type = $this->entityTypeManager->getDefinition($entity_type_id);
   

   why this change? Seems to be causing coding standard errors.

You can omit the composer.json and doxygen change if you want. You do have to
Remove the array type hint since drush passes an iterable object and not an array during batch processing.

Hm, that seems a bit unfortunate change in drush if it's not compatible then with core batch handling :)

anyway, we can remove the type hint, but we need to have a type or multiple types in the @param docs, otherwise phpcs complains.

Drush has passed an Iterable for years. It didn't matter back then since nobody used type hints! A module can type hint on Iterable if it only supports PHP 7.1+. See https://steemit.com/php/@crell/php-never-type-hint-on-arrays. And yes, the whole situation is slightly unfortunate.

As for the Doxygen, it would be valid to use Iterable|array or just Iterable

Removed the composer.json changes and changed the doc comment.

Works well for me, thanks !
RTBC +1

Thanks, committed.