Capitalize the name of the module, because module names are proper nouns.
Also according to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#10 stripe_webform-3079903-10.patch447 bytessolideogloria
#8 stripe_webform-3079903-8.patch447 bytessolideogloria
#2 stripe_webform-info-3079903-2.patch397 bytesalonaoneill

Issue fork stripe_webform-3079903

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new stripe_webform-info-3079903-2.patch397 bytes
chris matthews’s picture

chris matthews commented
Status: Needs review » Reviewed & tested by the community

Good to go

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented

+1 RTBC

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Version: 8.x-1.x-dev » 2.x-dev
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Capitalize the name of the module and dependency namespacing in .info.yml file » Capitalize the name of the module and use namespaced dependencies in the .info.yml file
Version: 2.x-dev » 8.x-1.x-dev

This is an issue for the 8.x-1.x branch, since the other branch already uses name-spaced dependencies.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

The project name has been changed to Stripe's webform integration, which should instead be Stripe's Webform Integration.

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review
StatusFileSize
new stripe_webform-3079903-8.patch447 bytes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work 
-name: 'Stripe webform'
+name: 'Stripe's Webform Integration'
 type: module

It should be "Stripe's Webform Integration".

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review
StatusFileSize
new stripe_webform-3079903-10.patch447 bytes

Ah, thanks. The syntax highlighting didn't reveal that mistake.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Thank you! The last patch works as expected.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Version: 8.x-1.x-dev » 2.x-dev

Can we roll this for 2.x too?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

solideogloria opened merge request !5

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review

MR is for 2.x

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

The MR is good to go.

  • heddn committed 72e05368 on 2.x authored by solideogloria 
    Issue #3079903: Capitalize the name of the module and use namespaced...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.