Closed (fixed)
Project:
Scheduler
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Sep 2019 at 09:44 UTC
Updated:
13 Jun 2020 at 07:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
jonathan1055 commentedTo explain the above commit: our Travis test build was getting the Rules module code from github - https://github.com/fago/rules - because when we started using Travis this was an active repository with the latest Rules developments before they were committed to drupal.org. This was very useful when developing our Scheduler_Rules_Integration sub-module and its tests. However, this github repository is no longer being maintained and has slipped way behind the drupal.org version, so it is now preferrable to get the code from https://git.drupalcode.org/project/rules
One immediate benefit is that the number of Legacy Deprecation Notices listed in our Travis test log has dropped, due to some recent fixes in Rules code (Core 8.6 was 777 down to 642, core 8.7 was 1750 now down to 1615, and core 8.8 was 2214 now down to 2079). These are deprecation warnings created by Rules and Devel Generate, not by Scheduler's own code.
Comment #4
jonathan1055 commentedChange .travis.yml to add a PHP7.3/Core 8.8 combo to the build matrix.
Comment #6
jonathan1055 commentedMake PHPCS ignore all files which start with _ignore (as this helps to keep things cleaner).
Fail the Travis build if warnings are found by PHPCS (previously only coding standard errors would fail the build).
Comment #8
jonathan1055 commenteduse Drupal\Tests\Traits\Core\CronRunTrait in our SchedulerBrowserTestbase so we can remove cronRun() which was added as a temporary measure while we were still running at Core 8.2
Comment #11
jonathan1055 commentedIn tests, move the creation of a non-scheduler content type into SchedulerBrowserTestBase
Comment #14
jonathan1055 commentedComment #17
jonathan1055 commentedAdded extensions to phpcs.xml.dist following this Coder change #3074176: Allow extensions to be overridden in contrib phpcs.xml file
Comment #21
jonathan1055 commentedWhen running devel generate via drush there is (currently) no way to specify the scheduler publishing/unpublishing percent parameters. Hence
drush genc 1 -vwith verbose option on, shows:Fix will follow.
Comment #25
jonathan1055 commentedThe travis test at core 8.9 and PHP7.0 started failing recently with error
Line 571 is
Core 8 requires PHP7.0.8 minimum https://www.drupal.org/docs/8/system-requirements/php-requirements
Specifying 7.0 in .travis.yml loads 7.0.3 but there's no real need to test with 7.0.8 as we can simply change to PHP7.1.
Comment #26
jonathan1055 commentedCoder 8.3.9 has a new sniff which returns
Comment #28
jonathan1055 commentedScheduler 8.x-1.2 is now released