This issue will track the small miscellaneous adjustments to bits of code which do not need their own separate issue. It is better to have these recorded against an issue number in the commit log, rather than have them invisible here and only findable when viewing the actual commit list.

Comments

jonathan1055 created an issue. See original summary.

  • jonathan1055 committed 4fad8ec on 8.x-1.x
    Issue #3079645 by jonathan1055: In travis build get Rules from git....
jonathan1055’s picture

To explain the above commit: our Travis test build was getting the Rules module code from github - https://github.com/fago/rules - because when we started using Travis this was an active repository with the latest Rules developments before they were committed to drupal.org. This was very useful when developing our Scheduler_Rules_Integration sub-module and its tests. However, this github repository is no longer being maintained and has slipped way behind the drupal.org version, so it is now preferrable to get the code from https://git.drupalcode.org/project/rules

One immediate benefit is that the number of Legacy Deprecation Notices listed in our Travis test log has dropped, due to some recent fixes in Rules code (Core 8.6 was 777 down to 642, core 8.7 was 1750 now down to 1615, and core 8.8 was 2214 now down to 2079). These are deprecation warnings created by Rules and Devel Generate, not by Scheduler's own code.

jonathan1055’s picture

Change .travis.yml to add a PHP7.3/Core 8.8 combo to the build matrix.

  • jonathan1055 committed 8443508 on 8.x-1.x
    Issue #3079645 by jonathan1055: Add PHP7.3/Core 8.8 combo to .travis...
jonathan1055’s picture

Make PHPCS ignore all files which start with _ignore (as this helps to keep things cleaner).
Fail the Travis build if warnings are found by PHPCS (previously only coding standard errors would fail the build).

  • jonathan1055 committed 137131d on 8.x-1.x
    Issue #3079645 by jonathan1055: Exclude all _ignore* files from PHPCS...
jonathan1055’s picture

use Drupal\Tests\Traits\Core\CronRunTrait in our SchedulerBrowserTestbase so we can remove cronRun() which was added as a temporary measure while we were still running at Core 8.2

  • jonathan1055 committed b0ae389 on 8.x-1.x
    Issue #3079645 by jonathan1055: Remove cronRun() and use Drupal\Tests\...

  • jonathan1055 committed 92f9e26 on 8.x-1.x
    Issue #3079645 by jonathan1055: Improve readabilty of field names in...
jonathan1055’s picture

In tests, move the creation of a non-scheduler content type into SchedulerBrowserTestBase

  • jonathan1055 committed f01b221 on 8.x-1.x
    Issue #3079645 by jonathan1055: Move creation of a non-scheduler content...

  • jonathan1055 committed e584db6 on 8.x-1.x
    Issue #3079645 by jonathan1055: Add core 8.9 to Travis test build matrix
    
jonathan1055’s picture

  • jonathan1055 committed f16d9ad on 8.x-1.x
    Issue #3079645 by jonathan1055: Drop Travis testing at 8.6
    

  • jonathan1055 committed 0ba4aa5 on 8.x-1.x
    Issue #3079645 by jonathan1055: Add extensions to phpcs.xml.dist and fix...
jonathan1055’s picture

Added extensions to phpcs.xml.dist following this Coder change #3074176: Allow extensions to be overridden in contrib phpcs.xml file

  • jonathan1055 committed a91482b on 8.x-1.x
    Issue #3079645 by jonathan1055: Remove js from phpcs.xml extensions list
    

  • jonathan1055 committed 89003c9 on 8.x-1.x
    Issue #3079645 by jonathan1055: Add PHPstan to drupalci.yml for static...

  • jonathan1055 committed 4fb6c1d on 8.x-1.x
    Issue #3079645 by jonathan1055: Change $modules from public to protected...
jonathan1055’s picture

When running devel generate via drush there is (currently) no way to specify the scheduler publishing/unpublishing percent parameters. Hence drush genc 1 -v with verbose option on, shows:

 [info] Undefined index: scheduler_publishing scheduler.module:358
 [info] Undefined index: scheduler_unpublishing scheduler.module:359

Fix will follow.

  • jonathan1055 committed 9db402f on 8.x-1.x
    Issue #3079645 by jonathan1055: ->devel_generate['scheduler_publishing...

  • jonathan1055 committed 2291288 on 8.x-1.x
    Issue #3079645 by jonathan1055: Fix ->devel_generate['...

  • jonathan1055 committed 3ebe533 on 8.x-1.x
    Issue #3079645 by jonathan1055: Replace PHP7.0 with 7.1 in Travis build
    
jonathan1055’s picture

The travis test at core 8.9 and PHP7.0 started failing recently with error

ParseError: syntax error, unexpected ',', expecting ']'
core/lib/Drupal/Core/Database/Database.php:571

Line 571 is

    [, $module, $module_relative_namespace] = explode('\\', $namespace, 3);

Core 8 requires PHP7.0.8 minimum https://www.drupal.org/docs/8/system-requirements/php-requirements
Specifying 7.0 in .travis.yml loads 7.0.3 but there's no real need to test with 7.0.8 as we can simply change to PHP7.1.

jonathan1055’s picture

Coder 8.3.9 has a new sniff which returns

scheduler/scheduler.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 645 | WARNING | Exceptions should not be translated
     |         | (DrupalPractice.General.ExceptionT.ExceptionT)
----------------------------------------------------------------------

  • jonathan1055 committed 9c13a81 on 8.x-1.x
    Issue #3079645 by jonathan1055: Remove t( ) from exception message
    
jonathan1055’s picture

Status: Active » Fixed

Scheduler 8.x-1.2 is now released

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.