I would really like to see this module being covered by Drupal Security advisory policy. As per report the readme file is missing some content, so I added it.

CommentFileSizeAuthor
#5 interdiff-3079137-5-3.txt1.62 KBWebbeh
#5 3079137-5.patch2.14 KBWebbeh
#3 interdiff-3079137-2-3.txt2.35 KBWebbeh
#3 3079137-3.patch2.26 KBWebbeh
#2 recreate_block_content-updated_redme-3079137-2.patch1.1 KBdeaom

Comments

DeaOm created an issue. See original summary.

deaom’s picture

deaom commented
Status: Active » Needs review
StatusFileSize
new recreate_block_content-updated_redme-3079137-2.patch1.1 KB

And the patch.

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Title: Security advisory policy - update for Readme file » Update README file
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3079137-3.patch2.26 KB
new interdiff-3079137-2-3.txt2.35 KB

#2 needed work - specifically, hard-text wrapping at 80 characters and a CONFIGURATION section.

I've added this in a patch and interdiff, while also expanding the INTRODUCTION to be in line with the module page.

deaom’s picture

deaom commented
Status: Reviewed & tested by the community » Needs work

Hi @Webbeh. There are some errors in the text.

This Recreate Block Content module recreates the Block Content for a exported
Custom Block. It doe not export the content, the block is created as a
placeholder, with no content.

Should be

This Recreate Block Content module recreates the block content for exported custom block. It does not export the content. The block is created as a placeholder with no content.

and

This version also creates better titles for content blocks when possible and display messages on the site or drush when a block is created.

should be something like

This version also creates better titles for content blocks when possible and displays messages on the site or via drush when a block is created.

The configuration part just repeats what is already written in the introduction. So either remove it from introduction or write something else in the configuration. As it is a configuration I don't think explaining what the module does belongs here. It should be something in a sense of

This module does not have an user interface, so no configuration is needed. Just clear caches via drush or via drupal clear caches command in admin.

Everything else seems fine. I would also maybe change the .txt to. md.

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3079137-5.patch2.14 KB
new interdiff-3079137-5-3.txt1.62 KB

Changes per #3079137-4: Update README file applied. Patch and interdiff attached for review.

deaom’s picture

deaom commented
Status: Needs review » Reviewed & tested by the community

Hi @Webbeh, everything seems good, you left the readme in txt format which is fine, everything else I mentioned was corrected, so marking this as RTBC.

joao sausen’s picture

joao sausen commented

This is merged on 8.x-2.x-dev, needs testing.

joao sausen’s picture

joao sausen commented
Status: Reviewed & tested by the community » Fixed

Module was tested by pareview.sh and is now covered by Security advisory policy.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.