@see New 'core_version_requirement' key in info.yml files for modules and themes allows Composer semantic version constraints including specifying multiple major versions of core

CommentFileSizeAuthor
#5 webform-add-core-version-requirement-3077884-5-D8.patch359 bytesIhorMaster
#3 webform-3077884-add_core_version_requirement.patch365 bytesIhorMaster

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Title: [Webform 9.x-6.x] - Add 'core_version_requirement' key to webform.info.yml file » [Drupal 8.7.x] - Add 'core_version_requirement' key to webform.info.yml file
IhorMaster’s picture

IhorMaster commented
StatusFileSize
new webform-3077884-add_core_version_requirement.patch365 bytes

I added 'core_version_requirement' key to webform.info.yml file. Created a patch.

Here is the patch. Please review.

jrockowitz’s picture

jrockowitz commented
Status: Active » Postponed

The catch 22 is Webform 5.x won't be support Drupal 9.x

@see https://www.jrockowitz.com/blog/webform-road-to-drupal-9

IhorMaster’s picture

IhorMaster commented
Assigned: Unassigned » IhorMaster
Status: Postponed » Needs review
StatusFileSize
new webform-add-core-version-requirement-3077884-5-D8.patch359 bytes

jrockowitz, thank you for additional information about issue. I read your blog and I created new patch. Needs review

id.aleks’s picture

id.aleks commented
Assigned: IhorMaster » Unassigned
Status: Needs review » Postponed

@IhorMaster We declared that the webform module requires a 'drupal:system (>= 8.6)'. But in your patch, you set core_version_requirement: ^8, which means that this module is compatible with all versions of Drupal 8. Don't you think that this is some kind of collision?

IhorMaster’s picture

IhorMaster commented
Status: Postponed » Needs review

@id.aleks No, because key 'core_version_requirement' introduced in version 8.7.7. We can't set key core_version_requirement ^8.6 as an example. I tried and got exception
"The 'core_version_requirement' can not be used to specify compatibility for a specific version before 8.7.7"

jrockowitz’s picture

jrockowitz commented
Title: [Drupal 8.7.x] - Add 'core_version_requirement' key to webform.info.yml file » [Drupal 8.8.x] - Add 'core_version_requirement' key to webform.info.yml file

I think the answer is that this patch is not really needed until Drupal 8.8.x is the only supported version.

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Postponed

  • IhorMaster authored 1d702f6 on 8.x-5.x 
    Issue #3077884 by IhorMaster: [Drupal 8.8.x] - Add '...
jrockowitz’s picture

jrockowitz commented
jrockowitz’s picture

jrockowitz commented
Status: Postponed » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.