Starting with Drupal 8.4.x Drush 8 is no longer supported. Ref https://docs.drush.org/en/master/install/#drupal-compatibility

Since Drupal 8.3.x is EOL we should remove the Drush 8 integration. This task is needed to complete #3023170: Test for compatibility with Drupal 9.

Note that for the D7 version we will still need Drush 8.

CommentFileSizeAuthor
#10 3077570-10--remove_drush_8_support.patch14.98 KBdrunken monkey
#3 3077570-3.patch14.95 KBpfrenssen

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Related issues: +#3023170: Test for compatibility with Drupal 9
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Active » Needs review
StatusFileSize
new 3077570-3.patch14.95 KB
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Parent issue: » #3077570: Remove Drush 8 support from the 8.x branch
Related issues: -#3023170: Test for compatibility with Drupal 9
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Parent issue: #3077570: Remove Drush 8 support from the 8.x branch » #3023170: Test for compatibility with Drupal 9

Marking this as a child issue of #3023170: Test for compatibility with Drupal 9.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Drush 8 still works perfectly fine on 8.7 :)

pfrenssen’s picture

pfrenssen
Location Sofia
commented

Oh I see now, it is marked as "Supported, but not recommended".

I guess we are stuck with it for the lifetime of Drupal 8.x :(

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs review » Closed (duplicate)

Closing this. I had originally split this off from #3023170: Test for compatibility with Drupal 9 because I thought it was actionable right now but I was mistaken.

Since we cannot do this now and have to wait for Drupal 9 it is easier to handle this alongside the other deprecations that need to wait for Drupal 9. These are tackled in #3023170: Test for compatibility with Drupal 9.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Closed (duplicate) » Postponed
Issue tags: +Drupal 9.0 dependency

Re-opening based on #3023170-42: Test for compatibility with Drupal 9.
We want to commit the patch there a few months before the Drupal 9 release, at which point Drush 8 will still be supported (for Drupal 8) for a while. The search_api.drush.inc file will just be ignored there, so no harm. We should only finally remove this once we move to Drupal 9 completely, I think (i.e., don’t even support 8.9 anymore).

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Postponed » Needs review
StatusFileSize
new 3077570-10--remove_drush_8_support.patch14.98 KB

Have depended on Drupal 9 for quite a while now, so time to commit this.
Attaching a re-roll and will still wait a few days for any feedback/remarks, but otherwise I’ll just commit this.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Committed. Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.