Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Failure on sqlite:
https://www.drupal.org/pift-ci-job/1384628
I think it's not waiting for the CKEditor to initialize before clicking on the button.
Proposed resolution
I think it should use CKEditorTestTrait::waitForEditor() before trying to click the button.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | 3076609-14.patch | 4.86 KB | oknate |
| #14 | 3076609-14--fail.patch | 811 bytes | oknate |
| #11 | 3076609-11.patch | 3.05 KB | oknate |
| #2 | 3076609-2.patch | 1.81 KB | oknate |
| #2 | 3076609-2--fail.patch | 811 bytes | oknate |
Comments
Comment #2
oknateHere's a patch and a fail patch.
Comment #3
oknateComment #4
cilefen commentedComment #5
wim leersSo we're making a timing-sensitive test assertion be non-time sensitive. 👍
Comment #6
wim leersComment #9
catchCommitted/pushed to 8.8.x and cherry-picked to 8.7.x, thanks!
Comment #10
oknateThank you! There's a problem, though.
This will fail on 8.7 without also committing CKEditorTestTrait.php.
It was added in #2994699: Create a CKEditor plugin to select and embed a media item from the Media Library, which is not in 8.7.
Either that trait needs to committed, or this need to be reverted in the 8.7 branch.
Comment #11
oknateHere's a patch to add CKEditorTestTrait.
Comment #13
larowlanReverted on 8.7.x - can you post a combined patch with #11 and #2?
Thanks
Comment #14
oknatePosting combined patch of #2 and #11, and reposting the fail patch from #2.
Comment #15
wim leersComment #17
catchWhoops, reminder that backports fail in ways other than the patch not applying. Committed the combined patch with the trait to 8.7.x, thanks!
Comment #18
oknateFantastic, thanks for helping to get this resolved!