Hello,
if i declare 'is_list' = 'FALSE' in custom ProcessorPlugin, this is ignoring and going to parent::isList(). I think is bug, Please see patch.

Comments

Adrian Liegmann created an issue. See original summary.

idebr’s picture

Status: Active » Needs review
drunken monkey’s picture

Title: If i declare 'is_list' = 'FALSE' this is ignoring and going to parent::isList(). » Property definition ignores 'is_list' => FALSE
Component: General code » Framework
Status: Needs review » Fixed

Thanks for reporting this issue!

Not sure whether I’d call it a bug, though. The assumption that data definitions that implement ListDataDefinitionInterface represents lists seems a pretty sound one to me.
However, it’s true that it might be confusing to ignore 'is_list' => FALSE, as the intention seems quite obvious.
So, yes, makes sense to change this behavior, as it might be a bit of a DX WTF.

I refactored slightly to avoid the over-long lines and committed.
Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ushma’s picture

I am using version "8.x-1.17" and it contains this patch as per changelog.txt but I am still facing this issue.
I have added 'is_list' => FALSE in my custom processor for string field but in elastic I see "myfield": [ "xyz" ] where I was expecting "myfield": "xyz".

Can you please me to solve this out?