Remove unused use statements

Hi bertonha, thanks for reporting this issue!

After applying the patch there are still a few unused use statements in the Redirect repository. I suggest we clean these up as well:

$ phpcs . --sniffs=Drupal.Classes.UnusedUseStatement --standard=Drupal

FILE: /.../tests/src/Unit/RedirectRequestSubscriberTest.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
 8 | WARNING | [x] Unused use statement
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------


FILE: /.../modules/redirect_404/src/Render/Redirect404LogSuppressor.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 7 | WARNING | [x] Unused use statement
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

Applying Patch. Please Review.

Thanks! phpcs . --sniffs=Drupal.Classes.UnusedUseStatement --standard=Drupal no longer reports any unused statements.

Hello @berdir, any news here?

Patch no longer applies cleanly, and there are two more unused use statements:

FILE: ./redirect/tests/src/Functional/RedirectUITest.php
------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


FILE: ./redirect/src/EventSubscriber/RedirectRequestSubscriber.php
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------

Please review the patch.

the patch needed a reroll.

I'll do the review.

I will leave it in needs review because I found a unused use statement in Drupal\Tests\redirect\Functional\GlobalRedirectTest. Sending new patch and a interdiff.

The patch in #13 applies correctly and solves all warnings about unused use statements.

Assigning to myself as I'm triaging all RTBC issues.

I'm crediting everyone on this issue although the patch didn't fully apply. I manually fixed the missing item. Merge will happen shortly. See notes below.

@mahipal46 @Deeksha B In the future, please include an interdiff when updating unless it's a reroll. If it's a reroll, then explain that. Thanks.

@anagomes Thanks for the review. It would be good to know how you reviewed when marking something RTBC. In this case, I assume you ran phpcs . --sniffs=Drupal.Classes.UnusedUseStatement --standard=Drupal after applying the patch but it's important to be explicit in your comment so we know how something has been tested/reviewed. Thanks.

patch worked for these:

[ok] * modules/redirect_404/src/Render/Redirect404LogSuppressor.php
-use Drupal\Core\Logger\LoggerChannelFactory;

[ok] * modules/redirect_404/tests/src/Functional/Redirect404TestBase.php
-use Drupal\Component\Render\FormattableMarkup;

[ok] * redirect.generate.inc
-use Drupal\Component\Utility\Random;

[ok] * redirect.module
-use Drupal\Core\Database\Query\Condition;

[ok] * src/Plugin/Field/FieldWidget/RedirectSourceWidget.php
-use Drupal\Component\Utility\NestedArray;

[ok] * tests/src/Functional/GlobalRedirectTest.php
-use Drupal\Core\Cache\Cache;

[ok] * tests/src/Functional/RedirectUITest.php
-use Drupal\Component\Render\FormattableMarkup;

manually fixed with phpcbf . --sniffs=Drupal.Classes.UnusedUseStatement --standard=Drupal:

[ok] * tests/src/Unit/RedirectCheckerTest.php
-use Symfony\Cmf\Component\Routing\RouteObjectInterface; [used in commented-out code]

rejected in patch:

* tests/src/Unit/RedirectCheckerTest.php
* tests/src/Unit/RedirectRequestSubscriberTest.php

Merged. This will be included in the next release.