Recognized by the Search API Solr tests on travis. Latest tests for patches here in the issue queue fail for the same reason:

Behat\Mink\Exception\ExpectationException: The string "" was not found anywhere in the HTML response of the current page.

/Users/markus.kalkbrenner/workspace/git/drupal/vendor/behat/mink/src/WebAssert.php:768
/Users/markus.kalkbrenner/workspace/git/drupal/vendor/behat/mink/src/WebAssert.php:324
/Users/markus.kalkbrenner/workspace/git/drupal/core/tests/Drupal/Tests/WebAssert.php:429
/Users/markus.kalkbrenner/workspace/git/drupal/modules/contrib/search_api/tests/src/Functional/IntegrationTest.php:306
CommentFileSizeAuthor
#12 3073283-12--fix_tests--followup.patch3.48 KBdrunken monkey
#7 3073283-6.patch4.36 KBidebr
#7 interdiff-4-6.txt628 bytesidebr
#4 3073283.patch3.76 KBmkalkbrenner
#2 failing.patch281 bytesmkalkbrenner

Comments

mkalkbrenner created an issue. See original summary.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Active » Needs review
StatusFileSize
new failing.patch281 bytes

Just triggering the existing tests without any code change!

Status: Needs review » Needs work

The last submitted patch, 2: failing.patch, failed testing. View results

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 3073283.patch3.76 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3073283.patch, failed testing. View results

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

The patch in #4 did not yet solve the issue. But at least we now see what plugin might cause the issue: "No UI datasource" 

1) Drupal\Tests\search_api\Functional\IntegrationTest::testFramework
Behat\Mink\Exception\ExpectationException: The string "No UI datasource" was not found anywhere in the HTML response of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:768
/var/www/html/vendor/behat/mink/src/WebAssert.php:324
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:429
/var/www/html/modules/contrib/search_api/tests/src/Functional/IntegrationTest.php:303
/var/www/html/modules/contrib/search_api/tests/src/Functional/IntegrationTest.php:99
idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-4-6.txt628 bytes
new 3073283-6.patch4.36 KB

Removed hidden plugins from the "responseContains" assertion.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs review » Reviewed & tested by the community

I confirm that this fixes the Solr tests, too: https://travis-ci.org/mkalkbrenner/search_api_solr/builds/571270726

  • borisson_ committed 3093b26 on 8.x-1.x authored by idebr 
    Issue #3073283 by mkalkbrenner, idebr: Test are failing on Drupal Core 8...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks for fixing this so quickly. Other issues should be able to get back to green now as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Priority: Critical » Normal
Status: Closed (fixed) » Needs review
StatusFileSize
new 3073283-12--fix_tests--followup.patch3.48 KB

Thanks a lot again for fixing this so swiftly while I was unavailable!

I don’t think the descriptions are really necessary, though, if we skip checking them anyways?
Patch attached, let’s see what the test bot says.

  • drunken monkey committed 60500e8 on 8.x-1.x 
    Follow-up to #3073283 by drunken monkey: Fixed failing tests on Drupal...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Test bot agrees, so: committed.
Thanks again, everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.