Problem/Motivation

Need to remove depricated methods from block module, Further description https://www.drupal.org/project/drupal/issues/2716163

Proposed resolution

Create a patch that can replace entityManager to entityTypeManager and other depricated methods

User interface changes

BLock help text

API changes

None

CommentFileSizeAuthor
#7 block_deprecation_8.8.x-3073108-7.patch1.03 KBbadrange
#3 block_depreciation-1.patch2.65 KBuditrawat
block_depreciation.patch5.32 KBuditrawat

Comments

uditrawat created an issue. See original summary.

uditrawat’s picture

uditrawat
Primary language English
commented
uditrawat’s picture

uditrawat
Primary language English
commented
Issue tags: -depricated +deprecated
StatusFileSize
new block_depreciation-1.patch2.65 KB
cilefen’s picture

cilefen commented
Title: Deprecated function removal » Remove calls to deprecated code in the block module
Issue tags: -block
badrange’s picture

badrange commented

What is the best target for this patch, 8.8.x or 8.7.x? I have a feeling it will be ignored when it is marked for 8.7.5.

cilefen’s picture

cilefen commented
Version: 8.7.5 » 8.8.x-dev
Parent issue: #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch » #3038170: Drupal core's own deprecation testing results

First, the parent issue was wrong. This is about fixing calls. #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch is about actually removing deprecated functions. This is not a bug fix, so 8.8.x.

badrange’s picture

badrange commented
StatusFileSize
new block_deprecation_8.8.x-3073108-7.patch1.03 KB

When rerolling this patch for 8.8.x I notice that most of the changes in the patch have already been committed. Attaching a patch with the only change that is left.

core/modules/system/system.module indeed state: 

/**
 * Return only visible regions.
 *
 * @deprecated in Drupal 8.3.x and will be removed before Drupal 9.0.0.
 *   Use \Drupal\block\BlockRepositoryInterface::REGIONS_VISIBLE instead.
 *
 * @see system_region_list()
 * @see https://www.drupal.org/node/2831620
 */
const REGIONS_VISIBLE = 'visible';
badrange’s picture

badrange commented
Status: Active » Needs review
badrange’s picture

badrange commented

Is this now a duplicate of https://www.drupal.org/project/drupal/issues/2807961 ?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Closed (duplicate)

We don't update deprecated calls per module (anymore), I'd say this is a duplicate of #3015812: Introduce new Theme extension object and properly deprecate REGIONS_VISIBLE and REGIONS_ALL at this point as that's the only thing that's left. That's a more specific issue than #9.