Comments

ilchovuchkov created an issue. See original summary.

vuil’s picture

StatusFileSize
new91.92 KB
vuil’s picture

StatusFileSize
new1.3 KB
vuil’s picture

Status: Active » Needs review
vuil’s picture

Issue summary: View changes
damienmckenna’s picture

renatog’s picture

Status: Needs review » Needs work
+++ b/easy_social.module
@@ -502,3 +502,28 @@ EOT;
+    $readme_file = file_exists(__DIR__ . '/README.md') ? __DIR__ . '/README.md' : __DIR__ . '/README.txt';
+    if (!file_exists($readme_file)) {
+      return NULL;
+    }

Why are we verifying if there is a README.md or README.txt if we already know that ES have README.txt

I think we can go directly with README.txt, since we already have txt and not markdown

renatog’s picture

Issue tags: +Needs reroll

And the patch to be rerolled

renatog’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new700 bytes
new1.16 KB

Follow the new patch rerolled and with the suggestion addressed at #7 to use use directly README.txt since we know that we don't have Markdown

Thank you so much @vuil

damienmckenna’s picture

I think it's worth our time to convert the file to Markdown: #2932827

renatog’s picture

Totally agree, +1

renatog’s picture

Status: Needs review » Needs work

So I'm backing to "Needs Work" to use the other approach loading from Markdown if exists

sourabhjain’s picture

Status: Needs work » Needs review
StatusFileSize
new900 bytes
new673 bytes

Updated the hook_help() in which checked if README.md file exist than loaded it otherwise loaded README.txt.

renatog’s picture

Status: Needs review » Reviewed & tested by the community

Amazing!! The #13 really looks good. Have this logic with Markdown that we talked before

+1 to RTBC

Thank you so much for your contribution, @sourabhjain

damienmckenna’s picture