Reviewed & tested by the community
Project:
Easy Social
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Aug 2019 at 06:26 UTC
Updated:
26 Aug 2024 at 11:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
vuilComment #3
vuilComment #4
vuilComment #5
vuilComment #6
damienmckennaComment #7
renatog commentedWhy are we verifying if there is a README.md or README.txt if we already know that ES have README.txt
I think we can go directly with README.txt, since we already have txt and not markdown
Comment #8
renatog commentedAnd the patch to be rerolled
Comment #9
renatog commentedFollow the new patch rerolled and with the suggestion addressed at #7 to use use directly README.txt since we know that we don't have Markdown
Thank you so much @vuil
Comment #10
damienmckennaI think it's worth our time to convert the file to Markdown: #2932827
Comment #11
renatog commentedTotally agree, +1
Comment #12
renatog commentedSo I'm backing to "Needs Work" to use the other approach loading from Markdown if exists
Comment #13
sourabhjainUpdated the hook_help() in which checked if README.md file exist than loaded it otherwise loaded README.txt.
Comment #14
renatog commentedAmazing!! The #13 really looks good. Have this logic with Markdown that we talked before
+1 to RTBC
Thank you so much for your contribution, @sourabhjain
Comment #15
damienmckenna