Closed (fixed)
Project:
Gutenberg
Version:
8.x-1.5
Component:
Code
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Aug 2019 at 13:43 UTC
Updated:
7 May 2021 at 13:39 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
sayco commentedI've created a child issue https://www.drupal.org/project/gutenberg/issues/3074249 for replacing file_prepare_directory function.
We need to think of the approach for the first issue.
First, we need to determine if we still gonna use this script.
I couldn't find any place where this file is used, but if it is, then we should really think of rewriting it to some kind of service, to instantiate the service correctly in Drupal.
From what I can see this script handle overwriting the libraries.yml file for new libraries (nodes modules etc.) If so, should rather make it dynamically in hook instead of rewriting the file I suppose.
Comment #3
marcofernandes commentedgutenberg-dependencies.php is a build script. It generates the gutenberg.libraries.yml file with all the info from gutenberg core packages. Should be only used when upgrading Gutenberg packages and build a module release.
Comment #4
marcofernandes commentedComment #6
marcofernandes commentedComment #7
rpsuAdded a few comments in https://git.drupalcode.org/project/gutenberg/commit/741b9b6
Comment #8
gmangones commented@rpsu what are the errors or warnings reported on Gutenberg module? how can i contribute.
Thank's
Comment #9
gmangones commentedHi, was added compatibility drupal 9 for gutenberg module.
Thank's
Comment #10
henrikakselsen commentedLooks like this was added on both branches
- https://git.drupalcode.org/project/gutenberg/-/blob/8.x-1.11/gutenberg.i...
- https://git.drupalcode.org/project/gutenberg/-/blob/8.x-2.x/gutenberg.in...
Closing. Please reopen if I was mistaken.