Running Upgrade Status Beta1 for Drupal 8

According to http://hojtsy.hu/blog/2019-jul-19/first-beta-upgrade-status-drupal-8-out... the Upgrade Status module can scan you modules for Drupal 9 readiness.

I've done a scan locally using Drupal Gutenberg 8.x-1.5 and got the following warnings:

Upgrade Status report

Contributed modules and themes

Gutenberg Editor 8.x-1.5

Scanned on Mon, 08/05/2019 - 15:31.
2 warnings found.

Our goal is that Drupal Gutenberg will have a stable release for Drupal 9 when Drupal 9 is released.

Status File name Line Error
Check manually modules​/​contrib​/​gutenberg​/​scripts​/​gutenberg-dependencies.php Class scanDir was not found while trying to analyse it - autoloading is probably not configured properly.
Fix later modules​/​contrib​/​gutenberg​/​src​/​Controller​/​MediaController.php 135 Call to deprecated function file_prepare_directory(). Deprecated in Drupal 8.7.0, will be removed before Drupal 9.0.0.
Use ​\​Drupal​\​Core​\​File​\​FileSystemInterface::prepareDirectory().

Remaining tasks

Decide what needs to be done for the warnings and create related issues to them.

CommentFileSizeAuthor
#9 d9-gutenberg-3072711-9.patch372 bytesgmangones
Skjermbilde 2019-08-05 kl. 15.38.15.png76.83 KBthorandre
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thorandre created an issue. See original summary.

sayco’s picture

sayco CreditAttribution: sayco commented

I've created a child issue https://www.drupal.org/project/gutenberg/issues/3074249 for replacing file_prepare_directory function.

We need to think of the approach for the first issue.
First, we need to determine if we still gonna use this script.
I couldn't find any place where this file is used, but if it is, then we should really think of rewriting it to some kind of service, to instantiate the service correctly in Drupal.
From what I can see this script handle overwriting the libraries.yml file for new libraries (nodes modules etc.) If so, should rather make it dynamically in hook instead of rewriting the file I suppose.

marcofernandes’s picture

marcofernandes CreditAttribution: marcofernandes at Frontkom commented

gutenberg-dependencies.php is a build script. It generates the gutenberg.libraries.yml file with all the info from gutenberg core packages. Should be only used when upgrading Gutenberg packages and build a module release.

marcofernandes’s picture

marcofernandes CreditAttribution: marcofernandes at Frontkom commented
Related issues: +#3074249: Deprecated function file_prepare_directory()

marcofernandes’s picture

marcofernandes CreditAttribution: marcofernandes at Frontkom commented
Status: Active » Needs review
rpsu’s picture

rpsu
he/him
Primary language Finnish
CreditAttribution: rpsu as a volunteer commented
Status: Needs review » Needs work

Added a few comments in https://git.drupalcode.org/project/gutenberg/commit/741b9b6

gmangones’s picture

gmangones CreditAttribution: gmangones as a volunteer and at weKnow Inc commented

@rpsu what are the errors or warnings reported on Gutenberg module? how can i contribute.

Thank's

gmangones’s picture

gmangones CreditAttribution: gmangones at weKnow Inc commented
Status: Needs work » Needs review
FileSize
d9-gutenberg-3072711-9.patch372 bytes

Hi, was added compatibility drupal 9 for gutenberg module.

Thank's

henrikakselsen’s picture

henrikakselsen CreditAttribution: henrikakselsen at Frontkom commented
Status: Needs review » Fixed

Looks like this was added on both branches
- https://git.drupalcode.org/project/gutenberg/-/blob/8.x-1.11/gutenberg.i...
- https://git.drupalcode.org/project/gutenberg/-/blob/8.x-2.x/gutenberg.in...

Closing. Please reopen if I was mistaken.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.