Drupal 9 Deprecated Code Report

drupal-check -ad account_settings_tab

 ------ --------------------------------------------------------------------------------- 
  Line   src/Form/AccountSettingsTabForm.php                                              
 ------ --------------------------------------------------------------------------------- 
  30     \Drupal calls should be avoided in classes, use dependency injection instead     
  31     \Drupal calls should be avoided in classes, use dependency injection instead     
  32     \Drupal calls should be avoided in classes, use dependency injection instead     
  38     \Drupal calls should be avoided in classes, use dependency injection instead     
  41     \Drupal calls should be avoided in classes, use dependency injection instead     
  76     Call to deprecated method hashEquals() of class Drupal\Component\Utility\Crypt:  
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                
         Use PHP's built-in hash_equals() function instead.                               
  76     \Drupal calls should be avoided in classes, use dependency injection instead     
  93     Call to deprecated method url() of class Drupal\Core\Form\FormBase:              
         in drupal:8.0.0 and is removed from drupal:9.0.0.                                
         Use \Drupal\Core\Url::fromUri() instead.                                         
  115    \Drupal calls should be avoided in classes, use dependency injection instead     
  116    \Drupal calls should be avoided in classes, use dependency injection instead     
  133    \Drupal calls should be avoided in classes, use dependency injection instead     
  164    \Drupal calls should be avoided in classes, use dependency injection instead     
  173    Call to deprecated function drupal_set_message():                                
         in drupal:8.5.0 and is removed from drupal:9.0.0.                                
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.             
  183    Call to deprecated function drupal_set_message():                                
         in drupal:8.5.0 and is removed from drupal:9.0.0.                                
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.             
  191    Call to deprecated function drupal_set_message():                                
         in drupal:8.5.0 and is removed from drupal:9.0.0.                                
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.             
 ------ --------------------------------------------------------------------------------- 
                                                                                                              
 [ERROR] Found 15 errors                                                                                                

Applied patch #5, and fixed other issues in the above list.

Updated patch.

Hi.
I ran the upgrade status test after I applied the patch and It had one warning that the core_version_requirement: ^8 || ^9 is missing from the .info.yml file. I created a new patch.

Looks, good to me, Thanks for the contribution...

This is marked fixed but no code was committed. Moving back to RTBC.

Hmm... maybe this was fixed? I see a commit in the commit log. Normally a commit comment would show up in this issue like this:

https://www.drupal.org/project/galleryslider/issues/3139135#comment-1363...

How are you committing these patches?

(p.s. sorry for the noise... it took me 3 issues before I realized that there was something else going on.)

Fyi, after discussing this with others, it appears that because this issue is for a different version (branch) than what the code was committed to, the commit comment won't show up here. You could probably get the commit to show up by 1) moving this back to RTBC, 2) switching the version to 3.0.0 (now that it exists), and 3) marking Fixed again. Never mind, I forgot this the commit comment happens during the commit.