Drupal 9 readiness / compatibility

As of June 3, 2019, CDN's daily test run started failing due to new deprecations. See https://www.drupal.org/pift-ci-job/1309175. Change record: https://www.drupal.org/node/3035273.

Fixed those. And yay, it means one less service to inject! 🥳

#2 contained mistakes.

As of June 12, 2019, CDN's daily test run started gained another failure due to new deprecations. See https://www.drupal.org/pift-ci-job/1318016. Change record: https://www.drupal.org/node/3056869.

Fixed.

Yay, down to 1 failure on 8.8! More failures on 8.7 make sense, since this patch is making the CDN module use 8.8-only APIs.

That one failure actually is also due to a change in Drupal 8.8.

As of July 30, 2019, CDN's daily test run has one actually failing test. See https://www.drupal.org/pift-ci-job/1362511. #3019393: Avoid query strings for aggregated CSS files (like JS) caused this failure:

1) Drupal\Tests\cdn\Functional\CdnIntegrationTest::testCss
Failed asserting that 0 is identical to 1.

Fixed.

This is ready. Hopefully marking this RTBC will automatically re-test the RTBC patch against 8.8, but I'm not sure we'll be so fortunate. I think Drupal.org will use the default issue patch testing core branch, which is 8.7. We'll find out. 😊

I'll work on this next Friday at DrupalCon Amsterdam 🙂

Renaming per http://hojtsy.hu/blog/2019-oct-16/join-imadedrupal9-drupalcon-amsterdam-....

Drupal 8.8.0 has been released. Let's re-run tests for #6 and land this!

+++ b/src/CdnFarfutureController.php
@@ -66,7 +66,7 @@ class CdnFarfutureController {
-    if (!$request->query->has('relative_file_url') || ($scheme !== FileUrlGenerator::RELATIVE && !$this->fileSystem->validScheme($scheme))) {
+    if (!$request->query->has('relative_file_url') || ($scheme !== FileUrlGenerator::RELATIVE && !$this->streamWrapperManager->isValidScheme($scheme))) {

+++ b/src/File/FileUrlGenerator.php
@@ -121,7 +111,7 @@ class FileUrlGenerator {
-    if (!$scheme = $this->fileSystem->uriScheme($uri)) {
+    if (!$scheme = StreamWrapperManager::getScheme($uri)) {

Unfortunately, these changes can only be made if the CDN module requires Drupal 8.8.

But Drupal 8.7 is still supported.

OTOH, the CDN module has been stable for a long time now. I think it's reasonable to have release 8.x-3.3 (from >6 months ago) be the last release that supported Drupal 8.6 and 8.7.

People will only need to update to the next version of the CDN module if they want Drupal 9 compatibility.

The test re-runs had soft failures due to new coding standards being accepted by Drupal core (see #3063323: Update drupal/coder to 8.3.6), which means the CDN module automatically inherits those too.

Per #15, bumping the version requirement to Drupal 8.8.

To declare Drupal 9 compatibility, we must specify the new core_version_requirement key in cdn.info.yml. Because we're dropping support for Drupal 8.7, it's also safe to remove the core key. 🥳

Alright, truly ready for Drupal 9 now!