Closed (fixed)
Project:
Cookiebot - Cookie consent, Cookie monitoring and Cookie control
Version:
8.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
30 Jul 2019 at 11:38 UTC
Updated:
14 Mar 2022 at 08:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
arnested commentedComment #3
c960657 commentedTypo:
Comment #4
arnested commentedThank you, Christian (long time no see)!
Fixed patch uploaded.
Comment #5
a.milkovskyThanks for the patch!
Afaik "\'" is not the right way for translated strings.
Use "double quotes" if some chars should be escaped. See \Drupal\Core\Cache\Context\UserRolesCacheContext::getLabel.
In addition let's call it "Use the current Drupal language ...". Unfortunately the Drupal language does not exist yet :)
Comment #6
a.milkovskyComment #7
arnested commentedYou are right. Its one of the things I actually know but always gets wrong anyway :)
:)
Fixed.
New patch attached.
Comment #8
arnested commentedActually, when introducing support for the data-culture attribute we should also use it on the cookie declaration block.
Updated patch attached.
Comment #9
bibliophileaxeThis still doesn't work if we language fallback module. If we are using 2 language, the langcode would be something like language1-language2, in this case, the culture attribute doesn't work. Added an alter hook to alter the langcode as needed.
Comment #10
nachosalvador commentedI applied patch #8 and works as expected.
Comment #11
tijsdeboeckI've tested patch #8 as well, indeed works as expected!
Comment #12
bramdriesenRTBC +1
Comment #14
bramdriesen