Drupal 9 Deprecated Code Report

This should be using dependency injection not using a static call to \Drupal::messenger()

Hello, please review my patch!

Reviewed patch #7
Works well for me. Thanks!

+1 RTBC

Running drupal-check on HEAD of OpenAPI, with this patch applied, still gives me an error:

------ ----------------------------------------------------------------------------- 
  Line   openapi.install                                                              
 ------ ----------------------------------------------------------------------------- 
  14     Call to deprecated function system_rebuild_module_data():                    
         in drupal:8.8.0 and is removed from drupal:9.0.0.                            
         Use \Drupal::service('extension.list.module')->getList() instead.            
         Note: use reset() only when you really need to rescan and rebuild the list.  
 ------ ----------------------------------------------------------------------------- 

Attached is a patch which fixes this one too.

Hmm...it looks like the test will need to be updated for compatibility with the path_alias module in D8.8. I'll leave that to someone else who knows more than I do, and possibly a follow-up issue.

+++ b/tests/src/Functional/RequestTest.php
@@ -373,6 +373,11 @@ class RequestTest extends BrowserTestBase {
+    // @todo Update the expectations to include path alias stuff, and then
+    // delete these unset() calls.
+    unset($decoded_response['definitions']['path_alias--path_alias']);
+    unset($decoded_response['paths']['/path_alias/path_alias']);
+    unset($decoded_response['paths']['/path_alias/path_alias/{entity}']);

This is because in Drupal 8.8, path aliases became entities. Makes sense to not fix that here, to keep scope tight.

Thanks, @richgerdes!

Thanks all for working on this! I've committed the patch against 1.x and opened #3110131: Upgrade tests to be compatible with path_alias module in D8.8 to track fixes in the tests. These issues were already fixed when the 2.x version was implemented.