Hi,

Custom composite field +/- buttons icon's height was previoulsy set in webform.element.multiple.css file at .webform-multiple-table td input[type="image"] declaration which seems to be missing in 8.x-5.3 update resulting in ugly oval buttons instead of circle ones.
This can be fixed by adding an height: auto; line to the same .webform-multiple-table td input[type="image"] declaration.

I'm not sure if this an intended behaviour or the best way to fix it, but it works for my project ;-)

CommentFileSizeAuthor
#4 3069402-4.patch367 bytesjrockowitz
composite-icon-height.patch463 bytesphily

Comments

Phil Y created an issue. See original summary.

phily’s picture

phily
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
commented
Issue summary: View changes
jrockowitz’s picture

jrockowitz commented

What base theme are you using?

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3069402-4.patch367 bytes

The patch makes sense to me. Attached is the same patch rerolled from the webform module instead of the website root.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
phily’s picture

phily
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
commented

Thanks Jacob for reviewing and rerolling the patch.
I use Radix with Bootstrap 4 theme and I forget to check it against a core theme indeed..

  • jrockowitz authored 8e741ac on 8.x-5.x 
    Issue #3069402 by Phil Y, jrockowitz: Composite add/remove icons loose...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

I committed the patch because it works fine with core themes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.