Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
#2705433: Node should implement RevisionLogInterface deprecated Node::setRevisionAuthorId and Node::getRevisionAuthor and #2718583: Remove deprecated usages of Node::setRevisionAuthorId() and Node::getRevisionAuthor() removed its their use from core, but they don't trigger a deprecation error.
Proposed resolution
Add a deprecation error, and legacy test to finish the deprecation.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#4 | 3069033-4.drupal.Properly-deprecate-NodesetRevisionAuthorId.patch | 4.88 KB | mikelutz |
Comments
Comment #2
mikelutzComment #3
mikelutzComment #4
mikelutzComment #5
BerdirIt feels a bit weird to say "use Interface::method", especially since it's just a different method on the same object, but that was the message before and is basically what we usually do.
Looks fine, has legacy tests (was a bit confused first as they look identical, but they each use one deprecated message and once the replacement).
Comment #6
alexpottCommitted 347dbb0 and pushed to 8.8.x. Thanks!