Node should implement RevisionLogInterface

What we care about is the interface, the base class and trait are just a way to reduce boilerplate. It's fine if we can't.

So let's make NodeInterface and friends extend the new interface. Deprecate old methods that don't match (like Node's getRevisionAuthor(), since we now have getRevisionUser())

The patch looks good to me, I only found one small thing:

+++ b/core/modules/node/src/Entity/Node.php
@@ -6,6 +6,7 @@
+use Drupal\Core\Entity\RevisionLogInterface;

This use statement is not needed anymore.

+++ b/core/modules/node/src/Entity/Node.php
@@ -325,6 +332,44 @@ public function setRevisionAuthorId($uid) {
+   * {@inheritDoc}
...
+   * {@inheritDoc}
...
+   * {@inheritDoc}
+   */
...
+   * {@inheritDoc}

Nitpick, can be fixed on commit: We use {@inheritdoc}

Shouldn't the deprecated methods like getRevisionAuthor call the new methods like getRevisionUser()? I realise they're one-liners but makes the deprecation more explicit.

Where we add the deprecation notices we should say 'Use Blah\Blah instead' as well.

Also needs a follow-up to remove the usage of the deprecated functions and switch to the new ones - for example in Node::preSave().

+++ b/core/modules/node/src/NodeInterface.php
@@ -156,6 +157,7 @@ public function getRevisionAuthor();
    *   The called node entity.
    *
    * @deprecated in Drupal 8.2.0, will be removed before Drupal 9.0.0.
+   *   User setRevisionUserId() instead.
    */
   public function setRevisionAuthorId($uid);
 

Minor typo: User > Use :)

Perfect!

Committed f8fd764 and pushed to 8.2.x. Thanks!

+++ b/core/modules/node/src/NodeInterface.php
@@ -140,6 +141,9 @@ public function setRevisionCreationTime($timestamp);
+   *
+   * @deprecated in Drupal 8.2.0, will be removed before Drupal 9.0.0.
+   *   Use getRevisionUser() instead.
    */
   public function getRevisionAuthor();

@@ -151,6 +155,9 @@ public function getRevisionAuthor();
+   *
+   * @deprecated in Drupal 8.2.0, will be removed before Drupal 9.0.0.
+   *   Use setRevisionUserId() instead.
    */
   public function setRevisionAuthorId($uid);

Can we get a follow up to replace all usages? Ideally 8.2.0 will not have any. Also the reference to the method should be fully qualified.

diff --git a/core/modules/node/src/NodeInterface.php b/core/modules/node/src/NodeInterface.php
index 46fd77c..980dacd 100644
--- a/core/modules/node/src/NodeInterface.php
+++ b/core/modules/node/src/NodeInterface.php
@@ -142,8 +142,8 @@ public function setRevisionCreationTime($timestamp);
    * @return \Drupal\user\UserInterface
    *   The user entity for the revision author.
    *
-   * @deprecated in Drupal 8.2.0, will be removed before Drupal 9.0.0.
-   *   Use getRevisionUser() instead.
+   * @deprecated in Drupal 8.2.0, will be removed before Drupal 9.0.0. Use
+   *   \Drupal\Core\Entity\RevisionLogInterface::getRevisionUser() instead.
    */
   public function getRevisionAuthor();
 
@@ -156,8 +156,8 @@ public function getRevisionAuthor();
    * @return \Drupal\node\NodeInterface
    *   The called node entity.
    *
-   * @deprecated in Drupal 8.2.0, will be removed before Drupal 9.0.0.
-   *   Use setRevisionUserId() instead.
+   * @deprecated in Drupal 8.2.0, will be removed before Drupal 9.0.0. Use
+   *   \Drupal\Core\Entity\RevisionLogInterface::setRevisionUserId() instead.
    */
   public function setRevisionAuthorId($uid);
 

Fix made on commit.

Filed #2718583: Remove deprecated usages of Node::setRevisionAuthorId() and Node::getRevisionAuthor()

publish the change record