Boolean Field On and Off Label not Migrating

And here is a patch with a test.

Not sure why this is migrate critical, so removing the tag. Please let me know if I am wrong about that.

Ignore previous patch. I seem to be making quite a few bad patches in the last 24 hours.

Pretty reasonable (and simple) solution here. Test coverage and a quick break/fix.

this doesn't apply on 8.8, can we get a patch for 8.8?

Thanks

error: patch failed: core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceTest.php:150
error: core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceTest.php: patch does not apply
make: *** [patch88] Error 1

Rerolled. The interdiff fails but it is a small patch anyway.

AFAIK interdiffs are impossible by definition on a reroll.

re: rerolling + interdiff: that's right!

More info: https://www.drupal.org/documentation/git/interdiff#reroll

And back to RTBC.

+++ b/core/modules/field/src/Plugin/migrate/process/d7/FieldInstanceSettings.php
@@ -65,6 +65,13 @@ public function transform($value, MigrateExecutableInterface $migrate_executable
+      $field_data = unserialize($field_definition['data']);

should we be checking that these keys exists first to avoid warnings, we have null coalesce now, saves us triggering a warning?

$instance_settings['on_label'] = $field_data['settings']['allowed_values'][1] ?? 'On';
$instance_settings['off_label'] = $field_data['settings']['allowed_values'][0] ?? 'Off';

$field_data = unserialize($field_definition['data']); is actually done earlier and it will exist so it shouldn't be repeated here.

Instead of using coalesce this should really only set $instance_settings if there was an allowed value in the source.. The creation of the field will setup the default on/off labels so there is no need to do that here.

No interdiff since this is small patch.

LGTM

Committed 11c62ac and pushed to 8.8.x. Thanks!

Needs re-roll for 8.7.x

Reroll for 8.7

Simple reroll for 8.7.x and tests are passing. So setting back to RTBC.

Thanks!