Provide shipping_address condition for the commerce_order entity type

attached the same patch with some small improvements:

- removed unused declarations
- typo fix about $order vs $shipment
- prevent a fatal error if order's shipments are empty.

Updating to align with #3170419: Move all Shipping Conditions to the Shipping Category

Needs test before acceptance - can probably be replicated from commerce/modules/order/tests/src/Unit/Plugin/Commerce/Condition/OrderBillingAddressTest.php

Added tests.

added missed ShipmentAddressOrder.php file in #5

I've been thinking about this... And actually, we could provide this from Commerce directly.

The problem is, we already have a condition for the shipment, that adds a "Shipping address" condition under the "Customer" category (which means, on the shipping methods admin, we'll end up with a duplicate "Shipping address" condition.

Commerce could offer an OrderShippingAddress plugin (or eventually reuse the same plugin for both the billing & the shipping address, using a deriver.

Commerce has a collectProfiles() method on orders, that is what we should be using, and not get the address from the first shipment.

So I better understand the "Shipping address" condition under Customer applies to the billing address?

Without the patch I get the following:
I am currently trying to restrict to a zip code.
If the billing zipcode that I enter is in the allowed zip code but the shipping zip code is not in the allowed, shipping is still allowed.

I worked on the new condition. The problem is... I'm no longer sur why we actually need this :), since the Commerce shipping module provides a condition already?

Refreshed my memory, commerce_shipping provides a condition that works for shipments.

Under customer there is a shipping address condition.
Is that shipping condition applied to a customer, a person who has already purchased and has a saved shipping address on file? Can it be applied to anonymous users?

I do not know enough about the Customer shipping condition to know why this patch is needed. Or why the current customer shipping condition cannot provide a solution to what the person who posted this issue wanted.

Can anyone provide a little more guidance?

Went ahead and committed the patch.