Problem/Motivation

To make the UX simpler all shipping related Commerce Conditions should be in a Shipping Category; at the moment shipping address is in the Customer category - which like #3170417: Move payment gateway billing address condition to order group doesn't make sense.

Proposed resolution

Use a standard "Shipping" category for all Shipping related conditions.

Remaining tasks

  • ShipmentAddress Condition
  • ShipmentWeight Condition
  • Add comments on all patches with new Conditions
CommentFileSizeAuthor
#2 commerce_shipping-Shipping_Conditions_Category-3170419-2.patch1.09 KBdwkitchen

Comments

dwkitchen created an issue. See original summary.

dwkitchen’s picture

dwkitchen commented
StatusFileSize
new commerce_shipping-Shipping_Conditions_Category-3170419-2.patch1.09 KB
dwkitchen’s picture

dwkitchen commented
Status: Active » Needs review
dwkitchen’s picture

dwkitchen commented
Issue summary: View changes
rszrama’s picture

rszrama commented
Status: Needs review » Needs work

@dwkitchen The patch applies cleanly, but I'm wondering if we aren't creating a new inconsistency by putting "Shipping address" in a "Shipping" tab while "Billing address" remains on the "Order" tab. I suppose the challenge is that any given order will only have one billing address but may have more than one shipment, meaning it could have multiple shipping addresses.

I also wonder if we shouldn't keep the "Shipment" name for the tab and actually change it to "Shipment address". For reference, this tab will not appear in the Promotions or Payment gateways UIs for lack of the proper context. As such, it does make sense for the tab to be about an individual "Shipment" since that's what shipping will be quoted for.

dwkitchen’s picture

dwkitchen commented

These two conditions are both trying to provide the conditions you mention:

The first was putting the shipping method condition in the "order" which is probably not right. Both are limited by only considering the first shipment and may need multiple conditions;

  • Order contains shipment of type
  • All order shipments of type