I found the condition on item quantity to be missing from the module. In my case, what I was looking for is a condition such as "Quantity of all items in order is above 24" meaning that all order items were counted without any distinction on what they were. I am currently working on this feature which I think would be a fine addition to this module.

CommentFileSizeAuthor
#8 commerce_shipping-global-quantity-condition-3050162-8.patch5.39 KBkhiminrm
#5 commerce_shipping-global-quantity-condition-3050162-4.patch3.56 KBdwkitchen
#2 commerce_shipping-global-quantity-condition-3050162-0.patch4 KBtbalkwill-vupar

Issue fork commerce_shipping-3050162

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    tbalkwill-vupar created an issue. See original summary.

    tbalkwill-vupar’s picture

    tbalkwill-vupar commented
    StatusFileSize
    new commerce_shipping-global-quantity-condition-3050162-0.patch4 KB

    This patch adds a adjustable "Shipment quantity" condition to the already existing conditions in the Shipments tab of the Edit Shipping method page.

    tamerzg’s picture

    tamerzg commented
    Status: Active » Reviewed & tested by the community

    Patch works fine!

    dwkitchen’s picture

    dwkitchen commented
    Status: Reviewed & tested by the community » Needs work
    Related issues: +#3170419: Move all Shipping Conditions to the Shipping Category

    Updating patch to align with #3170419: Move all Shipping Conditions to the Shipping Category

    Needs tests before acceptance.

    dwkitchen’s picture

    dwkitchen commented
    StatusFileSize
    new commerce_shipping-global-quantity-condition-3050162-4.patch3.56 KB
    jsacksick’s picture

    jsacksick commented

    Let's use the Calculator to sum up quantities.

    Also, the patch has several coding standard issues (missing spaces between operators and $variables), false should be FALSE.

    And as mentioned, we're missing a test. Let's write a unit test (similar to what we're doing for similar condition plugins (i.e OrderItemQuantityTest).

    khiminrm’s picture

    khiminrm commented
    Assigned: tbalkwill-vupar » khiminrm
    khiminrm’s picture

    khiminrm commented
    StatusFileSize
    new commerce_shipping-global-quantity-condition-3050162-8.patch5.39 KB

    I've created patch with code fixes and unit test.

    khiminrm’s picture

    khiminrm commented
    Status: Needs work » Needs review
    jsacksick’s picture

    jsacksick commented
    Status: Needs review » Reviewed & tested by the community

    I think this is good to go! @dwkitchen: could you confirm?

    • jsacksick committed 234b117 on 8.x-2.x authored by khiminrm 
      Issue #3050162 by tbalkwill-vupar, khiminrm, dwkitchen, jsacksick: Add...
    jsacksick’s picture

    jsacksick commented
    Status: Reviewed & tested by the community » Fixed

    Added the condition to the schema.yml and committed. Thanks everyone!

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.