Ensure that PHPCS is passing in the module.

Issue fork api_proxy-3066644

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

e0ipso created an issue. See original summary.

anabpv’s picture

anabpv
she/her
Location Portugal 🇵🇹
commented
Assigned: Unassigned » anabpv
Status: Active » Needs work

I will work on this

anabpv opened merge request !2

anabpv’s picture

anabpv
she/her
Location Portugal 🇵🇹
commented
Assigned: anabpv » Unassigned
Status: Needs work » Needs review

Ran phpcs and phpcbf after applied the above fixes and the results came clean.

Waiting for review.

tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi

I'll review this!

tmaiochi’s picture

tmaiochi commented
Assigned: tmaiochi » Unassigned
Status: Needs review » Reviewed & tested by the community

The code removed all messages from PHPCS, and everything is working well as far as I can test it. Moving to RTBC!

anabpv’s picture

anabpv
she/her
Location Portugal 🇵🇹
commented

Apologies for the incorrect information. I have corrected it.

m4olivei made their first commit to this issue’s fork.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented

Thanks all! Merged to 8.x-1.x

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Reviewed & tested by the community » Fixed
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: Unassigned » m4olivei
Status: Fixed » Needs work

Oops! I noticed that this change caused an error on the plugin config form. I'll fix that.

m4olivei opened merge request !3

  • m4olivei committed 3079f37 on 8.x-1.x 
    Issue #3066644 by anabpv, m4olivei: Fix PHPCS again
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Version: 8.x-1.0-alpha3 » 8.x-1.x-dev
Assigned: m4olivei » Unassigned
Status: Needs work » Fixed

There we go. Should be good now.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Version: 8.x-1.x-dev » 2.x-dev

Oh well that's embarrassing. I didn't realize there was a 2.x branch when I committed this. All good that it went to 1.x as well. But lets get it into 2.x as well 😳.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: Unassigned » m4olivei
Status: Fixed » Active

m4olivei opened merge request !5

  • m4olivei committed bd84e46 on 2.x 
    Issue #3066644 by m4olivei, anabpv: Fix PHPCS
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: m4olivei » Unassigned
Status: Active » Fixed

There we go, merged to 2.x. I also took the opportunity to flesh out some code documentation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.