Closed (fixed)
Project:
Menu Block
Version:
8.x-1.x-dev
Component:
Miscellaneous
Priority:
Major
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
8 Jul 2019 at 19:45 UTC
Updated:
20 May 2020 at 07:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mattbloomfield commentedI don't know if this helps, and I apologize if it doesn't, but I've been applying some patches manually since I couldn't patch them all at once as the lines the patch alters had been changed by other patches. The file I've attached is the entire module I'm using, which has the following patches/features not in the current Dev version for download:
-Menu titles as links
-Fixed parent item
-Dropdown select to use as Menu title (working with Menu title as link patch)
-Hide pages not included in menu
-Make the initial visibility level follow the active menu item.
-Select whether or not the initial visibility level will be the active menu item or the children of the active menu item
I've also used the 'Upgrade Status' module and drupal-check commands to scan for any Drupal 9 deprecations. None are present in the current dev version and none are present in what I'm uploading.
Once again, I'm not even sure this is the right place to put this, as I'm not an actual contributer to the project. I just needed some patches applied for features I needed on my site and decided to share the combined patches in a complete module. I wrote none of the patches and deserve none of the credit. Here's where I pulled the patches from:
https://www.drupal.org/project/menu_block/issues/2884514
https://www.drupal.org/project/menu_block/issues/2950943
https://www.drupal.org/project/menu_block/issues/2756675
https://www.drupal.org/project/menu_block/issues/3007225
https://www.drupal.org/project/menu_block/issues/3040666
Comment #3
chris matthews commented@maintainers, it would be great to be able to have the following commits out of -dev as well as the pending commits from the current 8.x RTBC issues. Would 8.x-1.6 release be possible soon?
Commit 5edaded on 8.x-1.x for #2932048: Config schema mismatch for expand(ed)
Commit d88297c on 8.x-1.x for #2983880: Apply new {project}:{module} format for dependencies in info.yml
Commit a62e8fb on 8.x-1.x for #2981885: No 'Edit Menu' functionality in Settings Tray
Commit 79c1eef on 8.x-1.x for #2756675: Add option to make the starting level follow the active menu item
Comment #4
mattbloomfield commentedHi,
I saw this the dev version of the module was updated this morning, which is great. I also noticed that some of the patches I've applied over time weren't included yet. I thought I'd take the opportunity to add those back into the latest dev version, which I've attached here. As with my initial comment, I didn't create any of the patches, just applied them manually to add functionality. The latest dev version included the fixed parent menu item, but I added:
I also kept the schema updates. Basically, I touched the src/Plugin/Block/MenuBlock.php file, added some things there, and kept everything in the latest dev version the same. I merged what I needed to merge to add the functionality back in. I scanned it with the Upgrade Status module, and no deprecations for Drupal 9 came up. Let me know if anyone has any questions, and hopefully these features can make it into a release.
Comment #5
alisonHi there! Just checking in -- I'm so happy we've got several items mentioned on #2757143: [Meta] Add missing features to Drupal 8 menu_block committed to the module -- maybe we could steal from that task description to get this release task description started? Or just "call it" and make current dev be 1.6...? Jkjk I know that's not great process, just throwing it out there :)
And/or, I'll just re-share what @Chris Matthews shared -- the RTBC issue list :D
https://www.drupal.org/project/issues/menu_block?text=&status=14&priorit...
..........
And/or, maintainers, what can we do to help, what blockers do you see?
Thank you!
Comment #6
nkraftSeconding (or thirding at this point) interest in seeing a 1.6 release in the near future, including all the patches aforementioned by @alisonjo315 and @mattbloomfield above. Thank you for all your hard work on keeping this module alive!
Comment #7
joelpittetIf I just released what's in dev without any further commits, would anybody here be sad?
Comment #8
dwwI think lots of us would be "sad" if #2809699: Add configuration options for dynamic block titles wasn't in the next release. I believe it's only 'Needs work' due to weirdness from the test bot. I just re-queued the latest patch there now...
Comment #9
dwwSee also #3118828: MenuBlockTest should define defaultTheme
Comment #10
aaronbaumanI've been juggling this patch for a couple years now, would love to get it into a release.
#2809699: Add configuration options for dynamic block titles
I'll try to add some test coverage to get it back to NR
Comment #11
anybody@Maintainer:
1.6 was released on April 24th - Are all child issues part of that and this can be closed FIXED or update the title to 8.x-1.7?
Comment #12
dww@Anybody: Nope. https://www.drupal.org/project/menu_block/releases/8.x-1.6 shows you what was included. That's not everything from here.
IMHO we could create a new "Plan for Menu block 8.x-1.7 release" issue, move things from here to there that didn't make it into 8.x-1.6, and then call this fixed.
Thanks,
-Derek
Comment #13
anybodyThanks @dww :)
I did that: #3134036: [META] Plan for Menu block 8.x-1.7 release