Problem/Motivation

On a site that is using paragraphs fields on taxonomy terms the taxonomy_post_update_make_taxonomy_term_revisionable is taking hours. If the paragraphs fields are removed the update is quick.

I think this is a bug because the currently in HEAD updates can take hours.

Proposed resolution

Leverage #3066439: Stop invoking pre-save methods in EntityStorageInterface::restore() in \Drupal\entity_reference_revisions\Plugin\Field\FieldType\EntityReferenceRevisionsItem::preSave()

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 3066440-3.patch592 bytesalexpott
#2 3066440-2.patch680 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Related issues: +#3066439: Stop invoking pre-save methods in EntityStorageInterface::restore()
StatusFileSize
new 3066440-2.patch680 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 3066440-3.patch592 bytes

I messed up the core patch. This is based on the new approach.

daniel.bosen’s picture

daniel.bosen
he/him
commented
Status: Needs review » Reviewed & tested by the community

As already reported in #3066439: Stop invoking pre-save methods in EntityStorageInterface::restore(), this works very well on our installation.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Postponed

With the current approach on #3066439: Stop invoking pre-save methods in EntityStorageInterface::restore() this patch is not necessary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Postponed » Closed (won't fix)

And that new approach was now committed, so closing this.