Problem/Motivation
FILE: /home/thallesvf/Desktop/lando/d8-contrib/modules/ctools/src/Form/AjaxFormTrait.php
---------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
16 | ERROR | [ ] Description for the @return value is missing
31 | ERROR | [ ] Description for the @return value is missing
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------
Proposed resolution
Clear code on src/Form/AjaxFormTrait.php
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3064664-4.patch | 677 bytes | raman.b |
| #2 | ctools-Clean-up_code_in_AjaxFormTrait-3064664-2-D8.patch | 884 bytes | thalles |
Comments
Comment #2
thallesFollow the patch!
Comment #3
chris matthews commentedThe patch in #2 needs a reroll.
Comment #4
raman.b commentedRe-rolled for latest dev branch
Comment #5
mrinalini9 commentedReviewed patch #4, looks good to me. It applied cleanly and removed all the errors as mentioned above. So, for me, it is RTBC.
Thanks!
Comment #6
thallesComment #9
joelpittetComment #11
joelpittetPushed to dev, thanks for the cleanup