Problem/Motivation

FILE: /home/thallesvf/Desktop/lando/d8-contrib/modules/ctools/src/Form/AjaxFormTrait.php
---------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
 16 | ERROR | [ ] Description for the @return value is missing
 31 | ERROR | [ ] Description for the @return value is missing
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------

Proposed resolution

Clear code on src/Form/AjaxFormTrait.php

Comments

thalles created an issue. See original summary.

thalles’s picture

Status: Needs work » Needs review
StatusFileSize
new884 bytes

Follow the patch!

chris matthews’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

The patch in #2 needs a reroll.

raman.b’s picture

Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new677 bytes

Re-rolled for latest dev branch

mrinalini9’s picture

Reviewed patch #4, looks good to me. It applied cleanly and removed all the errors as mentioned above. So, for me, it is RTBC.

Thanks!

thalles’s picture

Status: Needs review » Reviewed & tested by the community

joelpittet’s picture

  • joelpittet committed 2bc2954 on 8.x-3.x authored by raman.b
    Issue #3064664 by thalles, raman.b, Chris Matthews, mrinalini9, andrey....
joelpittet’s picture

Status: Reviewed & tested by the community » Fixed

Pushed to dev, thanks for the cleanup

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.