Return translated term name on taxonomy term views argument

1. +++ b/src/Plugin/views/argument/SearchApiTerm.php
   @@ -19,6 +21,47 @@ use Drupal\taxonomy\Entity\Term;
   +    /** @var static $plugin */
   

   We can remove this.

2. +++ b/src/Plugin/views/argument/SearchApiTerm.php
   @@ -19,6 +21,47 @@ use Drupal\taxonomy\Entity\Term;
   +   * Retrieves the entity repository.
   

   Sets

3. +++ b/src/Plugin/views/argument/SearchApiTerm.php
   @@ -19,6 +21,47 @@ use Drupal\taxonomy\Entity\Term;
   +   * Sets the entity repository.
   

   Retrieves

Swap the return values in the dochead of the get/setter and add a return $this in the setter.

Tests are broken, we'll have to add the entity repository in the tests.

Would have been useful if we had the EntityRepositoryTrait in Drupal 8.

Note: There's a Term::load() statement in SearchApiTerm::title(). Opened a follow up issue to fix this.

Tests are green, the patch looks good and was tested on our project.

Note: no specific test to check that we get the translated language was added, I would assume that getTranslationFromContext is fully covered so it would not add much value to test getTranslationFromContext() in search_api.

Note: no specific test to check that we get the translated language was added, I would assume that getTranslationFromContext is fully covered so it would not add much value to test getTranslationFromContext() in search_api.

I agree with this.

Thanks a lot for reporting this here and already providing a patch!
However, while it worked, the patch did have some problems which I have addressed in the attached revision. Please confirm this still looks and works OK for you and I can commit.

In my opinion, a regression test would have been nice, too, to make sure this doesn’t break again in the future, but if even Joris is OK without it, then I won’t insist.

#8 works fine for me. Thanks

Looks great

Great to hear, thanks for testing/reviewing!
Committed.