Problem/Motivation

@see #3028272: "Do not scheduled email if the action should be triggered in the past" does not appear to be working properly.

Proposed resolution

Split STATE_DRAFT into STATE_DRAFT_CREATED and STATE_DRAFT_UPDATE

Remaining tasks

  • Add STATE_DRAFT_CREATED and STATE_DRAFT_UPDATE to WebformSubmissioninterface
  • Update \Drupal\webform\Entity\WebformSubmission::getState
  • Convert WebformSubmissionInterface::STATE_DRAFT to ::STATE_DRAFT_CREATED and ::STATE_DRAFT_UPDATED
  • Write update hook that converts STATE_DRAFT to ::STATE_DRAFT_CREATED and ::STATE_DRAFT_UPDATED
  • Write code to account for old 'draft' ::isStateTriggered($state, $states)
  • DRAFT_CREATED and DRAFT_UPDATE as DRAFT to $states array.
  • Update tests

Notes

  • Still use STATE_DRAFT for filtering

User interface changes

  • Adding Draft created and updated to submission states

API changes

Plugins to be update
  • ActionWebformHandler
  • EmailWebformHandler
  • RemotePostWebformHandler

Data model changes

N/A

Release notes snippet

TDB

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

Title: Split STATE_DRAFT into STATE_DRAFT_CREATED and STATE_DRAFT_UPDATE » [Webform 8.x-5.4] Split STATE_DRAFT into STATE_DRAFT_CREATED and STATE_DRAFT_UPDATE

  • 4d86496 committed on 3064070-draft-state
    Issue #3064070: [Webform 8.x-5.4] Split STATE_DRAFT into...
jrockowitz’s picture

Status: Active » Needs review
FileSize
32.74 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3064070-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • 25b5f15 committed on 3064070-draft-state
    Issue #3064070 by jrockowitz: [Webform 8.x-5.4] Split STATE_DRAFT into...
jrockowitz’s picture

Status: Needs work » Needs review
FileSize
32.97 KB

The last submitted patch, 4: 3064070-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

Status: Needs review » Postponed
jrockowitz’s picture

Status: Postponed » Reviewed & tested by the community

  • jrockowitz authored 249fb76 on 8.x-5.x
    Issue #3064070 by jrockowitz: [Webform 8.x-5.4] Split STATE_DRAFT into...
jrockowitz’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.