Backport SupportedPhpVersion, BlacklistPhp72Versions and MinimumPhpVersion to D7. The basic building blocks landed with #3059742: Backport base readiness checker logic to 7.x, now we need to copy/paste and D7ify things.

CommentFileSizeAuthor
#8 3063127-8.patch7.5 KBheddn
#7 3063127-7.patch7.15 KBtatarbj
#5 3063127-5.patch7.52 KBheddn
#5 interdiff_4-5.txt5.37 KBheddn
#4 3063127-4.patch2.83 KBheddn
#4 interdiff_3-4.txt1.97 KBheddn
#3 3063127.patch2.8 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Component: Code » Checkers
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review
StatusFileSize
new 3063127.patch2.8 KB

Here, we set the minimum PHP version to 5.6 and blacklist php 7.2.0-7.2.2.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new interdiff_3-4.txt1.97 KB
new 3063127-4.patch2.83 KB
heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new interdiff_4-5.txt5.37 KB
new 3063127-5.patch7.52 KB
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs review » Needs work

For the first look, the patch seems more than what's in the scope of this issue, adding new files to the files[] in info file that are not present here. I would suggest to split up the work and possibly add generic files (semver/src/) from an earlier issue rather than here.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs work » Needs review
StatusFileSize
new 3063127-7.patch7.15 KB

Limiting the scope in the patch to refer only to the IS here (the info file updates are implemented in a bug report under #3064354: Missing file entries from info file)

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new 3063127-8.patch7.5 KB

Good catch in #6/#7. However, we don't need the files at all as we include them ourselves. But we do need the minimum php version. Re-roll attached w/ php constraint.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

Since this is a pretty straight forward backport and the lone feedback is addressed... going to land this.

  • heddn committed 2e5593b on 7.x-1.x 
    Issue #3063127 by heddn, tatarbj: Backport SupportedPhpVersion,...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.