Full Changelog

Pull Request: https://github.com/goalgorilla/open_social/pull/1426 https://github.com/goalgorilla/open_social/pull/1544

Comments

truls1502 created an issue. See original summary.

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
commented
Assigned: truls1502 » Unassigned
Issue summary: View changes
Status: Active » Needs review

Added PR

socialnicheguru’s picture

socialnicheguru commented
Priority: Normal » Major
Status: Needs review » Needs work
Related issues: +#3061321: Uncaught exception in Nodes and Members tabs in rc3

Please be aware of this issue:

https://www.drupal.org/project/group/issues/3061321#comment-13170926

group_membership.roles.permissions is in many of the OpenSocial modules and will have to be replaced.

Group rc3 release notes: https://www.drupal.org/project/group/releases/8.x-1.0-rc3

Cache contexts have received an overhaul, please check your code for deprecated ones. For security reasons, group_membership.roles.permissions has been removed!
Group permissions are now built, cached and can be altered during build time. This should hopefully increase site performance a lot.

I am bumping this up to major because there is no backwards compatibility once group rc3 is enabled and it will result in an error and white screen.

jaapjan’s picture

jaapjan commented
Title: Update drupal/group from 1.0-rc2 to 1.0-rc3 » Update drupal/group from 1.0-rc2 to 1.0-rc4
Priority: Major » Normal
jaapjan’s picture

jaapjan commented
Issue summary: View changes

I've made some more changes accordingly.

New PR here:
https://github.com/goalgorilla/open_social/pull/1544

jaapjan’s picture

jaapjan commented
Status: Needs work » Needs review
Related issues: +#3020883: Deprecate GroupPermission access plugin in favor of an argument_validator so it works out of the box with blocks and modules such as VBO

Ready for review. Also needed to change a patch and adjust some Behat tests, but all seems to be good now.

ronaldtebrake’s picture

ronaldtebrake commented
Status: Needs review » Fixed

  • jaapjan committed 0068849 on 8.x-7.x 
    Issue #3062452 by jaapjan: fix feature status after installation.
  • jaapjan committed 1104077 on 8.x-7.x
    Issue #3062452 by jaapjan: fix behat tests Groups link on /user.
  • jaapjan committed 87554f1 on 8.x-7.x
    Issue #3062452 by jaapjan: use patch 10 instead of 9 from #3020883.
  • jaapjan committed 9ba4823 on 8.x-7.x
    Issue #3062452 by jaapjan, truls1502: update group from 1.0-rc2 to 1.0-...
  • jaapjan committed a1d38a6 on 8.x-7.x
    Issue #3062452 by jaapjan, truls1502, SocialNicheGuru: change cache...
  • ronaldtebrake authored a87ecd8 on 8.x-7.x
    Merge pull request #1544 from goalgorilla/feature/3062452-group-update...
  • jaapjan committed d997105 on 8.x-7.x
    Issue #3062452 by jaapjan, ronaldtebrake: update patch for issue #...
  • jaapjan committed dfa9916 on 8.x-7.x
    Issue #3062452 by jaapjan: fix group-access-roles behat test.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.