Clicking "Queue all items for reindexing" gives the status message "The search index {name} was successfully reindexed." but reindexing has not yet occurred (i.e. need to click "Index now" button). Perhaps the message should be "The search index {name} was successfully queued for reindexing."

CommentFileSizeAuthor
#7 3062400-7--rephase_reindex_message.patch2.07 KBdrunken monkey
#7 3062400-7--rephase_reindex_message--interdiff.txt882 bytesdrunken monkey
#4 3062400-4--rephase_reindex_message.patch1.21 KBdrunken monkey

Comments

jonathan_hunt created an issue. See original summary.

jonathan_hunt’s picture

jonathan_hunt commented
Title: Reindexing UI misleading » Reindexing message in UI misleading
Issue summary: View changes
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Project: Search API Solr » Search API
Version: 8.x-3.1 » 8.x-1.x-dev

That's Search API itself and not specific for the Solr backend.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3062400-4--rephase_reindex_message.patch1.21 KB

You’re right, that isn’t very well phrased. Your suggestion makes more sense.
The attached changes that message, and also the display and log message in case of a failure. Would be great if you could review, then I’ll commit.

Status: Needs review » Needs work

The last submitted patch, 4: 3062400-4--rephase_reindex_message.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

This also needs to be updated in the test as well.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 3062400-7--rephase_reindex_message--interdiff.txt882 bytes
new 3062400-7--rephase_reindex_message.patch2.07 KB

Makes sense, of course.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

  • drunken monkey committed ec05736 on 8.x-1.x 
    Issue #3062400 by drunken monkey, jonathan_hunt, borisson_: Fixed the...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Thanks for reviewing again. Committed.
Thanks again, everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.