The update text might be improvable, it was a bit strange...
"entity_embed 8004 hook_update_n Installs the fake entity type."

CommentFileSizeAuthor
#2 3061071-2.patch443 bytesoknate

Comments

Anybody created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Active » Needs review
StatusFileSize
new 3061071-2.patch443 bytes 
- * Installs the fake entity type.
+ * Adds new entity type to remove dependency on node module.
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Category: Bug report » Task
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Usability

This improves update path usability.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Improve update hook suggestion » Improve entity_embed_update_8004()'s message when running update.php

  • Wim Leers committed a9d269f on 8.x-1.x authored by oknate 
    Issue #3061071 by oknate, Wim Leers, Anybody: Improve...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

🚢

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Sorry for that stupid title, Wim... Seems I was very very tired that evening... -.- ;)
Great work!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Your title was fine, I’m just a stickler for precision 🤓

oknate’s picture

oknate
Location Greater New York City Area
commented

I actually loved the original update title. But it was a bit confusing for those who didn't know why we were installing a fake entity.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.