Currently the module is missing a couple of config schema items.

Patch attached adds them to password_policy.schema.yml

CommentFileSizeAuthor
#7 3060910-8.patch1.06 KBjeroent
#6 3060910-6.patch1.05 KBjeroent
#4 3060910-4.patch1.08 KBjeroent
#3 3060910-3.patch429 bytesjeroent
add-missing-config-schema-items.patch1.39 KBjeroent

Comments

JeroenT created an issue. See original summary.

aohrvetpv’s picture

aohrvetpv commented

I don't understand this patch yet. For instance, unsure why the schema needs a uuid key.

Will try to figure it out later.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3060910-3.patch429 bytes

@AohRveTPV,

I was looking a bit deeper into this issue and you're right. It's not necessary to add those items. But we should change the type from 'mapping' to 'config_entity'. Drupal knows how to handle those items. Checked this behavior with config_inspector

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3060910-4.patch1.08 KB

Readded the config_export definition.

aohrvetpv’s picture

aohrvetpv commented

Thanks, this is making more sense to me. Why do we need langcode in config_export?

I understand why we need the other 5. Class ConfigEntityBase, which class PasswordPolicy extends, defines langcode, but it also defines other properties.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3060910-6.patch1.05 KB

@AohRveTPV,

You're right. Removed langcode from the config_export definition.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3060910-8.patch1.06 KB

Seems something went wrong with the patch.

aohrvetpv’s picture

aohrvetpv commented
Title: Add missing config schema items » Add missing config_export definition to password_policy config entity type

#6 looks like you manually edited the patch but didn't update the line counts: "+37,14" should be "+37,13".

Attempting to clarify issue title for commit.

  • AohRveTPV committed c4f3f8d on 8.x-3.x authored by JeroenT 
    Issue #3060910 by JeroenT: Add missing config_export definition to...
aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Fixed

These changes seem correct to me per https://www.drupal.org/node/1809494.

rosinegrean’s picture

rosinegrean commented
Issue tags: -DevDaysCluj +DevDaysTransylvania

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.