Problem/Motivation

use of deprecated functions on linkchecker.batch.inc

Proposed resolution

Replace deprecated functions on linkchecker.batch.inc

CommentFileSizeAuthor
#2 linkchecker-Replace_deprecated_functions_on_linkchecker.batch_.inc-3059427-2-D8.patch2.28 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new linkchecker-Replace_deprecated_functions_on_linkchecker.batch_.inc-3059427-2-D8.patch2.28 KB

Follow the patch!

hass’s picture

hass commented

If I'm not wrong - the file is no longer used. This is part of an outstanding cleanup of the codebase.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Can we delete?

hass’s picture

hass commented

Currently only https://www.drupal.org/u/pnagornyak can confirm this for sure.

pnagornyak’s picture

pnagornyak commented

We don`t use this file anymore, for batch functions we use helper services such as linkchecker.extractor_batch or linkchecker.checker_batch

hass’s picture

hass commented

I guess we may need batches to solve #3058040: Links are not added to database on scan

pnagornyak’s picture

pnagornyak commented

@hass what do you mean?
do you want to run a batch on cron?

hass’s picture

hass commented

Running a batch when we enable a field for link checking that was disabled before. When you enable a field it need to be scanned and all links extracted.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Fixed

I guess this issue can be closed since there is a separate issue to solve the batches problem.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.