Hi team, using the search_api module version 8.x-1.13 and can see the below warnings in drupal log messages, when editing the node or clear the cache.

Please help us to fix the warnings.

Warning: preg_replace(): Compilation failed: invalid UTF-8 string at offset 5219 in Drupal\search_api\Plugin\search_api\processor\Highlight->highlightField() (line 625 of modules/contrib/search_api/src/Plugin/search_api/processor/Highlight.php) 
#0 core/includes/bootstrap.inc(584): _drupal_error_handler_real(2, 'preg_replace():...', 'l...', 625, Array) 
#1 [internal function]: _drupal_error_handler(2, 'preg_replace():...', 'l...', 625, Array) 
#2 modules/contrib/search_api/src/Plugin/search_api/processor/Highlight.php(625): preg_replace('/(??<=[
x{0}...', '<strong>
0</str...', ' landing_page ') 
#3 modules/contrib/search_api/src/Plugin/search_api/processor/Highlight.php(615): Drupal\search_api\Plugin\search_api\processor\Highlight>highlightField('landing_page', '\xC0\xA2', false) 
#4 modules/contrib/search_api/src/Plugin/search_api/processor/Highlight.php(328): Drupal\search_api\Plugin\search_api\processor\Highlight->highlightField(Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue), Array) 
#5 modules/contrib/search_api/src/Plugin/search_api/processor/Highlight.php(257): Drupal\search_api\Plugin\search_api\processor\Highlight->highlightFields(Array, Array) 
#6 modules/contrib/search_api/src/Entity/Index.php(671): Drupal\search_api\Plugin\search_api\processor\Highlight->postprocessSearchResults(Object(Drupal\search_api\Query\ResultSet)) 
#7 modules/contrib/search_api/src/Query/Query.php(564): Drupal\search_api\Entity\Index->postprocessSearchResults(Object(Drupal\search_api\Query\ResultSet)) 
#8 modules/contrib/search_api/src/Query/Query.php(504): Drupal\search_api\Query\Query->postExecute() 
#9 modules/contrib/search_api/src/Plugin/views/query/SearchApiQuery.php(512): Drupal\search_api\Query\Query->execute() 
#10 core/modules/views/src/ViewExecutable.php(1426): Drupal\search_api\Plugin\views\query\SearchApiQuery->execute(Object(Drupal\views\ViewExecutable)) 
#11 core/modules/views/src/ViewExecutable.php(1454): Drupal\views\ViewExecutable->execute(NULL) 
#12 core/modules/views/src/Plugin/views/display/Page.php(183): Drupal\views\ViewExecutable->render() 
#13 core/modules/views/src/ViewExecutable.php(1630): Drupal\views\Plugin\views\display\Page->execute() 
#14 core/modules/views/src/Element/View.php(77): Drupal\views\ViewExecutable->executeDisplay('page', Array) 
#15 [internal function]: Drupal\views\Element\View::preRenderViewElement(Array) 
#16 core/lib/Drupal/Core/Render/Renderer.php(378): call_user_func(Array, Array) 
#17 core/lib/Drupal/Core/Render/Renderer.php(195): Drupal\Core\Render\Renderer->doRender(Array, false) 
#18 core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(226): Drupal\Core\Render\Renderer->render(Array, false) 
#19 core/lib/Drupal/Core/Render/Renderer.php(582): Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent

Warning: array_flip(): Can only flip STRING and INTEGER values! in Drupal\Core\Entity\EntityStorageBase->loadMultiple() (line 264 of core/lib/Drupal/Core/Entity/EntityStorageBase.php) 
#0 core/includes/bootstrap.inc(584): _drupal_error_handler_real(2, 'array_flip(): C...', '/mnt/www/html/l...', 264, Array) 
#1 [internal function]: _drupal_error_handler(2, 'array_flip(): C...', '/mnt/www/html/l...', 264, Array) 
#2 core/lib/Drupal/Core/Entity/EntityStorageBase.php(264): array_flip(Array) 
#3 core/lib/Drupal/Core/Entity/EntityStorageBase.php(249): Drupal\Core\Entity\EntityStorageBase->loadMultiple(Array) 
#4 core/modules/taxonomy/src/TermStorage.php(94): Drupal\Core\Entity\EntityStorageBase->load(Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue)) 
#5 modules/contrib/search_api/src/Plugin/search_api/processor/AddHierarchy.php(292): Drupal\taxonomy\TermStorage->loadParents(Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue)) 
#6 modules/contrib/search_api/src/Plugin/search_api/processor/AddHierarchy.php(267): Drupal\search_api\Plugin\search_api\processor\AddHierarchy->addHierarchyValues('taxonomy_term', Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue), 'parent', Object(Drupal\search_api\Item\Field)) 
#7 modules/contrib/search_api/src/Entity/Index.php(653): Drupal\search_api\Plugin\search_api\processor\AddHierarchy->preprocessIndexItems(Array) 
#8 modules/contrib/search_api/src/Entity/Index.php(969): Drupal\search_api\Entity\Index->preprocessIndexItems(Array) 
#9 modules/contrib/search_api/src/Utility/PostRequestIndexing.php(73): Drupal\search_api\Entity\Index->indexSpecificItems(Array) 
#10 core/lib/Drupal/Core/EventSubscriber/KernelDestructionSubscriber.php(51): Drupal\search_api\Utility\PostRequestIndexing->destruct() 
#11 [internal function]: Drupal\Core\EventSubscriber\KernelDestructionSubscriber->onKernelTerminate(Object(Symfony\Component\HttpKernel\Event\PostResponseEvent), 'kernel.terminat...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) 
#12 core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func(Array, Object(Symfony\Component\HttpKernel\Event\PostResponseEvent), 'kernel.terminat...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) 
#13 /vendor/symfony/http-kernel/HttpKernel.php(88): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.terminat...', Object(Symfony\Component\HttpKernel\Event\PostResponseEvent)) 
#14 /vendor/stack/builder/src/Stack/StackedHttpKernel.php(32): Symfony\Component\HttpKernel\HttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#15 core/lib/Drupal/Core/DrupalKernel.php(671): Stack\StackedHttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#16 index.php(22): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#17 () 
#20 core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(227): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) 
#21 core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(117): Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\CurrentRouteMatch)) 
#22 core/lib/Drupal/Core/EventSubscriber/MainContentViewSubscriber.php(90): Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\CurrentRouteMatch)) 
#23 [internal function]: Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object(Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent), 'kernel.view', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) 
#24 core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func(Array, Object(Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent), 'kernel.view', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) 
#25 /vendor/symfony/http-kernel/HttpKernel.php(156): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.view', Object(Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent)) 
#26 /vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) 
#27 modules/contrib/simple_oauth/src/HttpMiddleware/BasicAuthSwap.php(67): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#28 core/lib/Drupal/Core/StackMiddleware/Session.php(57): Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#29 core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#30 core/modules/page_cache/src/StackMiddleware/PageCache.php(184): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#31 core/modules/page_cache/src/StackMiddleware/PageCache.php(121): Drupal\page_cache\StackMiddleware\PageCache->fetch(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#32 core/modules/page_cache/src/StackMiddleware/PageCache.php(75): Drupal\page_cache\StackMiddleware\PageCache->lookup(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#33 modules/contrib/jsonapi/src/StackMiddleware/FormatSetter.php(41): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#34 core/modules/ban/src/BanMiddleware.php(50): Drupal\jsonapi\StackMiddleware\FormatSetter->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#35 core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#36 core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#37 /vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#38 core/lib/Drupal/Core/DrupalKernel.php(693): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) 
#39 index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) 
#40 {main}.

Warning: Illegal offset type in Drupal\Core\Entity\EntityStorageBase->getFromStaticCache() (line 172 of core/lib/Drupal/Core/Entity/EntityStorageBase.php) 
#0 core/includes/bootstrap.inc(584): _drupal_error_handler_real(2, 'Illegal offset ...', '/mnt/www/html/l...', 172, Array) 
#1 core/lib/Drupal/Core/Entity/EntityStorageBase.php(172): _drupal_error_handler(2, 'Illegal offset ...', '/mnt/www/html/l...', 172, Array) 
#2 core/lib/Drupal/Core/Entity/EntityStorageBase.php(268): Drupal\Core\Entity\EntityStorageBase->getFromStaticCache(Array) 
#3 core/lib/Drupal/Core/Entity/EntityStorageBase.php(249): Drupal\Core\Entity\EntityStorageBase->loadMultiple(Array) 
#4 core/modules/taxonomy/src/TermStorage.php(94): Drupal\Core\Entity\EntityStorageBase->load(Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue)) 
#5 modules/contrib/search_api/src/Plugin/search_api/processor/AddHierarchy.php(292): Drupal\taxonomy\TermStorage->loadParents(Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue)) 
#6 modules/contrib/search_api/src/Plugin/search_api/processor/AddHierarchy.php(267): Drupal\search_api\Plugin\search_api\processor\AddHierarchy->addHierarchyValues('taxonomy_term', Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue), 'parent', Object(Drupal\search_api\Item\Field)) 
#7 modules/contrib/search_api/src/Entity/Index.php(653): Drupal\search_api\Plugin\search_api\processor\AddHierarchy->preprocessIndexItems(Array) 
#8 modules/contrib/search_api/src/Entity/Index.php(969): Drupal\search_api\Entity\Index->preprocessIndexItems(Array) 
#9 modules/contrib/search_api/src/Utility/PostRequestIndexing.php(73): Drupal\search_api\Entity\Index->indexSpecificItems(Array) 
#10 core/lib/Drupal/Core/EventSubscriber/KernelDestructionSubscriber.php(51): Drupal\search_api\Utility\PostRequestIndexing->destruct() 
#11 [internal function]: Drupal\Core\EventSubscriber\KernelDestructionSubscriber->onKernelTerminate(Object(Symfony\Component\HttpKernel\Event\PostResponseEvent), 'kernel.terminat...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) 
#12 core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func(Array, Object(Symfony\Component\HttpKernel\Event\PostResponseEvent), 'kernel.terminat...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) 
#13 /vendor/symfony/http-kernel/HttpKernel.php(88): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.terminat...', Object(Symfony\Component\HttpKernel\Event\PostResponseEvent)) 
#14 /vendor/stack/builder/src/Stack/StackedHttpKernel.php(32): Symfony\Component\HttpKernel\HttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#15 core/lib/Drupal/Core/DrupalKernel.php(671): Stack\StackedHttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#16 index.php(22): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#17 {main}

Warning: Illegal offset type in Drupal\Core\Entity\ContentEntityStorageBase->getFromPersistentCache() (line 955 of core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php) 
#0 core/includes/bootstrap.inc(584): _drupal_error_handler_real(2, 'Illegal offset ...', '/mnt/www/html/l...', 955, Array) 
#1 core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(955): _drupal_error_handler(2, 'Illegal offset ...', '/mnt/www/html/l...', 955, Array) 
#2 core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php(356): Drupal\Core\Entity\ContentEntityStorageBase->getFromPersistentCache(Array) 
#3 core/lib/Drupal/Core/Entity/EntityStorageBase.php(279): Drupal\Core\Entity\Sql\SqlContentEntityStorage->doLoadMultiple(Array) 
#4 core/lib/Drupal/Core/Entity/EntityStorageBase.php(249): Drupal\Core\Entity\EntityStorageBase->loadMultiple(Array) 
#5 core/modules/taxonomy/src/TermStorage.php(94): Drupal\Core\Entity\EntityStorageBase->load(Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue)) 
#6 modules/contrib/search_api/src/Plugin/search_api/processor/AddHierarchy.php(292): Drupal\taxonomy\TermStorage->loadParents(Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue)) 
#7 modules/contrib/search_api/src/Plugin/search_api/processor/AddHierarchy.php(267): Drupal\search_api\Plugin\search_api\processor\AddHierarchy->addHierarchyValues('taxonomy_term', Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue), 'parent', Object(Drupal\search_api\Item\Field)) 
#8 modules/contrib/search_api/src/Entity/Index.php(653): Drupal\search_api\Plugin\search_api\processor\AddHierarchy->preprocessIndexItems(Array) 
#9 modules/contrib/search_api/src/Entity/Index.php(969): Drupal\search_api\Entity\Index->preprocessIndexItems(Array) 
#10 modules/contrib/search_api/src/Utility/PostRequestIndexing.php(73): Drupal\search_api\Entity\Index->indexSpecificItems(Array) 
#11 core/lib/Drupal/Core/EventSubscriber/KernelDestructionSubscriber.php(51): Drupal\search_api\Utility\PostRequestIndexing->destruct() 
#12 [internal function]: Drupal\Core\EventSubscriber\KernelDestructionSubscriber->onKernelTerminate(Object(Symfony\Component\HttpKernel\Event\PostResponseEvent), 'kernel.terminat...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) 
#13 core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func(Array, Object(Symfony\Component\HttpKernel\Event\PostResponseEvent), 'kernel.terminat...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) 
#14 /vendor/symfony/http-kernel/HttpKernel.php(88): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.terminat...', Object(Symfony\Component\HttpKernel\Event\PostResponseEvent)) 
#15 /vendor/stack/builder/src/Stack/StackedHttpKernel.php(32): Symfony\Component\HttpKernel\HttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#16 core/lib/Drupal/Core/DrupalKernel.php(671): Stack\StackedHttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#17 index.php(22): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#18 {main}

Warning: Illegal offset type in isset or empty in Drupal\Core\Entity\EntityStorageBase->load() (line 250 of core/lib/Drupal/Core/Entity/EntityStorageBase.php) 
#0 core/includes/bootstrap.inc(584): _drupal_error_handler_real(2, 'Illegal offset ...', '/mnt/www/html/l...', 250, Array) 
#1 core/lib/Drupal/Core/Entity/EntityStorageBase.php(250): _drupal_error_handler(2, 'Illegal offset ...', '/mnt/www/html/l...', 250, Array) 
#2 core/modules/taxonomy/src/TermStorage.php(94): Drupal\Core\Entity\EntityStorageBase->load(Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue)) 
#3 modules/contrib/search_api/src/Plugin/search_api/processor/AddHierarchy.php(292): Drupal\taxonomy\TermStorage->loadParents(Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue)) 
#4 modules/contrib/search_api/src/Plugin/search_api/processor/AddHierarchy.php(267): Drupal\search_api\Plugin\search_api\processor\AddHierarchy->addHierarchyValues('taxonomy_term', Object(Drupal\search_api\Plugin\search_api\data_type\value\TextValue), 'parent', Object(Drupal\search_api\Item\Field)) 
#5 modules/contrib/search_api/src/Entity/Index.php(653): Drupal\search_api\Plugin\search_api\processor\AddHierarchy->preprocessIndexItems(Array) 
#6 modules/contrib/search_api/src/Entity/Index.php(969): Drupal\search_api\Entity\Index->preprocessIndexItems(Array) 
#7 modules/contrib/search_api/src/Utility/PostRequestIndexing.php(73): Drupal\search_api\Entity\Index->indexSpecificItems(Array) 
#8 core/lib/Drupal/Core/EventSubscriber/KernelDestructionSubscriber.php(51): Drupal\search_api\Utility\PostRequestIndexing->destruct() 
#9 [internal function]: Drupal\Core\EventSubscriber\KernelDestructionSubscriber->onKernelTerminate(Object(Symfony\Component\HttpKernel\Event\PostResponseEvent), 'kernel.terminat...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) 
#10 core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func(Array, Object(Symfony\Component\HttpKernel\Event\PostResponseEvent), 'kernel.terminat...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) 
#11 /vendor/symfony/http-kernel/HttpKernel.php(88): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.terminat...', Object(Symfony\Component\HttpKernel\Event\PostResponseEvent)) 
#12 /vendor/stack/builder/src/Stack/StackedHttpKernel.php(32): Symfony\Component\HttpKernel\HttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#13 core/lib/Drupal/Core/DrupalKernel.php(671): Stack\StackedHttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#14 index.php(22): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\LocalRedirectResponse)) 
#15 {main}
CommentFileSizeAuthor
#14 3059312_allow_Solr_to_skip_regression_test_14.patch2.17 KBmkalkbrenner
#14 12-14-interdiff.txt587 bytesmkalkbrenner
#12 3059312_allow_Solr_to_skip_regression_test.patch1.94 KBmkalkbrenner
#6 3059312-6--add_hierarchy_type_check.patch2.22 KBdrunken monkey
#6 3059312-6--add_hierarchy_type_check--tests_only.patch1.03 KBdrunken monkey
#3 3059312-3--add_hierarchy_type_check.patch1.19 KBdrunken monkey

Comments

Ravi Shankar Karnati created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue summary: View changes

(Prettifying IS.)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Warnings in the drupal log messages , related to the Search_api module » Warnings in the drupal log messages
Component: General code » Plugins
Status: Active » Needs review
StatusFileSize
new 3059312-3--add_hierarchy_type_check.patch1.19 KB

For the first error, it just seems like invalid UTF-8 is passed as the fulltext keys to the highlighting processor. Without further information, it’s impossible to tell how it got there and whether this is a bug in the processor. (I guess we could check for whether the string is valud UTF-8 beforehand, but it seems weird to do that in the highlighting processor when the origin might be somewhere else, or even just user input. I feel that at a certain level we should be able to rely on getting valid UTF-8.

The other warnings seem pretty much identical, and stem from us trying to use a TextValue object as a taxonomy term ID for loading.
This seems to be caused by a weird setup where you index taxonomy term references (that is, their IDs) as “Fulltext” but then still want hierarchical information added to them. I think you probably want the labels, not IDs, but it doesn’t work that way. (If I misread the cause of the problem, and your setup, then sorry.)
Anyways, even if the underlying setup doesn’t really make sense, it should still not lead to warnings. Patch attached to fix that, please test/review!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

The addHierarchy fixes look good, you think we should add a testcase for this?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Actually - I am pretty sure we are going to need tests.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new 3059312-6--add_hierarchy_type_check--tests_only.patch1.03 KB
new 3059312-6--add_hierarchy_type_check.patch2.22 KB

You’re right, of course. Easy enough, too. (Interdiff == tests-only.)

The last submitted patch, 6: 3059312-6--add_hierarchy_type_check--tests_only.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Yup, green tests make me happy. RTBC :)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Alright, thanks again for reviewing!
Committed.

  • drunken monkey committed 13476f7 on 8.x-1.x 
    Issue #3059312 by drunken monkey, borisson_: Fixed warning when trying...
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Fixed » Needs work

The new regression test introduced by this patch causes the AddHierarchyTest to fail on the Solr backend.

You store term IDs like '1' or '2' as fulltext field. These values are ignored in Solr because the solr.LengthFilterFactory is set to min: 2 for the default text field.

Unfortunately I can't just overwrite this regression test because it is part of testPreprocessIndexItemsTaxonomy(). So I have to copy it entirely to https://git.drupalcode.org/project/search_api_solr/blob/8.x-3.x/tests/sr... and remove the regression test which would be bad choice!

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 3059312_allow_Solr_to_skip_regression_test.patch1.94 KB

Here's a quick and dirty patch that just isolates that test. This way Solr can skip the test and travis will turn green again.

Status: Needs review » Needs work

The last submitted patch, 12: 3059312_allow_Solr_to_skip_regression_test.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 12-14-interdiff.txt587 bytes
new 3059312_allow_Solr_to_skip_regression_test_14.patch2.17 KB
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

I committed the counterpart of part of a different bug I was working on, but travis now turned green again with the patch applied:
https://git.drupalcode.org/project/search_api_solr/commit/73d686a

See https://travis-ci.org/mkalkbrenner/search_api_solr/builds/550370155

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Sure, if it helps you, doesn’t really make a difference for us.
Slightly cleaned up the code and then committed.
Thanks!

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.