General task to update code and tests for Drupal 9 compatibility.

CommentFileSizeAuthor
#4 interdiff-3058857-2-4.txt21.99 KBscott_euser
#4 contact_emails-3058857-4.patch24.62 KBscott_euser
#2 contact_emails-3058857-2.patch4.27 KBDrupalZone

Comments

scott_euser created an issue. See original summary.

DrupalZone’s picture

DrupalZone commented
Status: Active » Needs review
StatusFileSize
new contact_emails-3058857-2.patch4.27 KB

php drupal-check.phar modules/contact_emails/
20/20 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ---------------------------------------------------
Line src/ContactEmailer.php
------ ---------------------------------------------------
106 Call to deprecated function drupal_set_message().
155 Call to deprecated function drupal_set_message().
------ ---------------------------------------------------
------ ---------------------------------------------------
Line src/Form/ContactEmailForm.php
------ ---------------------------------------------------
299 Call to deprecated function drupal_set_message().
360 Call to deprecated function drupal_set_message().
------ ---------------------------------------------------
------ -------------------------------------------------------------------------------------------------------------------------------------------------------
Line src/Tests/Update/ContactEmailsTableToEntityUpdateTest.php
------ -------------------------------------------------------------------------------------------------------------------------------------------------------
13 Class Drupal\contact_emails\Tests\Update\ContactEmailsTableToEntityUpdateTest extends deprecated class Drupal\system\Tests\Update\UpdatePathTestBase.
------ -------------------------------------------------------------------------------------------------------------------------------------------------------
------ ------------------------------------------------------------------------------------
Line tests/modules/contact_emails_test_mail_alter/contact_emails_test_mail_alter.module
------ ------------------------------------------------------------------------------------
16 Call to deprecated function drupal_set_message().
17 Call to deprecated function drupal_set_message().
18 Call to deprecated function drupal_set_message().
19 Call to deprecated function drupal_set_message().
24 Call to deprecated function drupal_set_message().
28 Call to deprecated function drupal_set_message().
------ ------------------------------------------------------------------------------------
[ERROR] Found 11 errors

Patch will resolve all errors

Status: Needs review » Needs work

The last submitted patch, 2: contact_emails-3058857-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

scott_euser’s picture

scott_euser commented
Status: Needs work » Needs review
StatusFileSize
new contact_emails-3058857-4.patch24.62 KB
new interdiff-3058857-2-4.txt21.99 KB

Thanks for starting on this! Was a bit of a ways off but updated patch gets it there and gets the tests working again.

  • scott_euser committed 909482a on 8.x-1.x 
    Issue #3058857 by scott_euser, DrupalZone: Drupal 9 compatibility -...
scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Updated

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.