Problem/Motivation

See the core issue for more information - #3057545: ResourceTypeRepository wrongly assumes that all entity reference fields have the setting "target_type". This issue here is there to provide support for contrib installations of the jsonapi module.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3057555-3.patch2.38 KBhchonov
#2 3057555-2.patch1.91 KBhchonov

Comments

hchonov created an issue. See original summary.

hchonov’s picture

hchonov
Primary language Bulgarian
Location Burgas
commented
Status: Needs review » Needs work
StatusFileSize
new 3057555-2.patch1.91 KB
hchonov’s picture

hchonov
Primary language Bulgarian
Location Burgas
commented
StatusFileSize
new 3057555-3.patch2.38 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +API-First Initiative, +Entity Field API, +DER issue
Related issues: +#3057545: ResourceTypeRepository wrongly assumes that all entity reference fields have the setting "target_type", +#3057556: Implement DERItem::getReferenceableBundles, +#3027430: Dynamic Entity Reference normalization support, +#3029090: Dynamic Entity Reference: support discovering relatable resource types, +#2844946: Add DynamicEntityReferenceItemNormalizer for serialization module

This might be a duplicate of #3029090: Dynamic Entity Reference: support discovering relatable resource types.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Note that for the remainder of the 8.8.x cycle, for JSON:API development the following applies:

  1. Commits must happen against Drupal 8.8.x core first, and are backported to 8.7.x when core policy allows this.
  2. Only commits to 8.7.x may be backported to the https://www.drupal.org/project/jsonapi contrib module (8.x-2.x)
  3. Therefore patches must be filed against the jsonapi.module component in Drupal core. But to speed up development, you can develop the patch in the https://www.drupal.org/project/jsonapi issue queue, since tests run much faster there.

So, closing this since #3057545: ResourceTypeRepository wrongly assumes that all entity reference fields have the setting "target_type" already exists against core's jsonapi.module :) Thanks for working on this, and sorry for the confusion and overhead!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Closed (duplicate)