Comments

truls1502 created an issue. See original summary.

truls1502’s picture

Assigned: truls1502 » Unassigned
Issue summary: View changes
Status: Active » Needs review

Added PR

jaapjan’s picture

Status: Needs review » Needs work

Unfortunately the add attachment feature is failing after update to field_group rc1. This still needs some work. Especially something in this function `social_comment_upload_form_comment_comment_form_alter` I think. In addition we should also implement https://www.drupal.org/project/paragraphs/issues/2907094.

jaapjan’s picture

There is a new update of Paragraphs:
https://www.drupal.org/project/paragraphs/releases/8.x-1.9

This should be updated together with field_group.

michaelschutz’s picture

Any update on this? field_group now has a stable 3.0 release. Do we have more of an indication when we'll be able to have both profile fields visible on registration (from what I understand, fixed in field_group 3.0-rc1) and adding attachments (from what I understand, broken by field_group 3.0-rc1) working?

ronaldtebrake’s picture

Status: Needs work » Fixed

https://github.com/goalgorilla/open_social/pull/1802 It's fixed in paralel with paragraphs.

michaelschutz’s picture

Thanks @ronaldtebrake so much for this. It will allow us to move forward with getting more people involved in our OS site.

I do have a further support request on this, though. On my test site I applied the changes to the files from that PR. When I updated using composer, paragraphs updated fine, but field_group didn't. When I why-not through composer, it's giving me the message that "goalgorilla/open_social 8.2.0 requires drupal/field_group (3.0-beta1)". When I try to composer update

I've verified that I made all the changes as per the PR, including to OS's composer.json. I don't see a composer.lock file in that directory (I've deleted the site root composer.lock), and I can't find any reference in any file in the whole codebase to figure out why OS 8.2 is still requiring field_group 3.0-beta1.

It's giving me the same error when I try to override the installation by using "composer require drupal/field_group:3.0" in my site root:

"Your requirements could not be resolved to an installable set of packages.

Problem 1
- goalgorilla/open_social 8.2.0 requires drupal/field_group 3.0-beta1 -> satisfiable by drupal/field_group[3.0.0-beta1] but these conflict with your requirements or minimum-stability."

Can you (or someone) point me in the right direction for how to fix this? I'm at a loss, particularly because paragraphs updated fine just using this PR.

Thanks in advance.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.