Problem

Counting group members originally had to load the user profiles of members to make sure the calculation matched the actual members within the group.

Solution

Removed custom group membership calculation which isn't necessary any more as it has been fixed within groups. Also generated group operation urls based on routes instead of custom paths.

Comments

royharink created an issue. See original summary.

royharink’s picture

royharink commented

PR: https://github.com/goalgorilla/open_social/pull/1406

kingdutch’s picture

kingdutch
he/him
Primary language English
commented

As a summary of the problem for future reference.

In group overviews we only show users that have a profile (because the profile is used for teasers). It could occur that a user existed without profile. This meant that a group could have 9 members but only 8 would be shown on the member overview. This can be confusing. Since then the profile creation has been fixed so that all users always have a profile. This means that the overview pages will correspond to the group member count.

The workaround that is removed in this issue is thus no longer needed. No issues were fixed within Group but the issues were fixed in Open Social/Profile so that the workaround is no longer needed.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Related issues: +#3032093: How to count group contents and members in a performance way

We may also want to check out this related issue since we don't actually need all the users but only a count.

ronaldtebrake’s picture

ronaldtebrake commented
Status: Needs review » Fixed

Will be in 4.14, 5.5 and 6.x :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.