Pathauto should have an extra.drush.services section in its composer.json

This patch should fixed the issue.

Removed extra comma at the end of line 13, sorry for not uploading interdiff.

I'm surprised this hasn't made more traction. After updating to Drush 9 in my build environments, I'm seeing this warning everywhere. A composer.json file is easy to add. I'm linking another, more recently logged, issue that also supplies a patch. I suggest a module maintainer review both and determine the most viable approach.

Hope to get this in soon!

+++ b/composer.json
@@ -0,0 +1,26 @@
+    "suggest": {
+        "redirect:redirect": "When installed Pathauto will provide a new \"Update Action\" in case your URLs change. This is the recommended update action and is considered the best practice for SEO and usability."
+    },

Should add the suggest section to match the project page's Recommended modules

+++ b/composer.json
@@ -0,0 +1,26 @@
+        "documentation": "https://www.drupal.org/docs/8/modules/pathauto",

Add documentation

+++ b/composer.json
@@ -0,0 +1,26 @@
+        "drupal/ctools": "^3.2",
+        "drupal/token": "^1.6"

Update required modules to a newer version

1. +++ b/composer.json
   @@ -0,0 +1,26 @@
   +    "suggest": {
   +        "redirect:redirect": "When installed Pathauto will provide a new \"Update Action\" in case your URLs change. This is the recommended update action and is considered the best practice for SEO and usability."
   +    },
   

   this doesn't seem right, this should be drupal/redirect? composer doesn't about drupal project/module naming.

2. +++ b/composer.json
   @@ -0,0 +1,26 @@
   +    "extra": {
   +        "drush": {
   +            "services": {
   +                "drush.services.yml": "^9"
   +            }
   +        }
   +    }
   +}
   

   lets include drush 10 compatibility.

Thanks @Berdir for reviewing!

Addressed #10

#10.1 yes, my bad. copied and pasted, did not notice that.

Thanks.

After more thinking, I'd prefer to not include the require definition for now. The generated information looks like this:

requires
drupal/core ^8.8 || ^9
drupal/ctools *
drupal/token *

Since we don't have any specific version requirement on those modules, I think that's good enough. Adding this would make it harder to e.g. test new major versions or so. Removed that part before committing. If we ever remove or add dependencies it's one place less to update.

Re #13 I am good with that, the drupal composer repository does not rely on composer.json to compute the dependencies as I read from somewhere I could not remember. Please correct me if I were wrong.

If composer.json is used to compute dependencies, it's good to have dependencies under the require section. So that, on a fresh installation, running drupal require drupal/pathauto only could get those relevant modules ready at the same time. or have to expand the composer require command to include them.

Not quite sure what you mean. If it's not there, then it will be added to the generated information automatically, composer require drupal/pathauto will definitely install all required dependencies, the only exception would be if you don't use the drupal.org composer repository but install it directly from a git repository or so.

@Berdir, what I meant is I was good with the removal you've made during committing. And your comment #16, confirmed that without dependencies under the require section of composer.json, composer require drupal/pathauto will install all required dependencies, that's the main reason I did agree with the removal.

Thanks!