Problem/Motivation

#2546212: Entity view/form mode formatter/widget settings have no translation UI adds a new ConfigMapper type. We need to add support to that one so they can be translated with Lingotek.

Proposed resolution

Add support for EntityDisplayMapper.

Remaining tasks

TBD

User interface changes

TBD

API changes

TBD

Data model changes

TBD

Release notes snippet

TBD

CommentFileSizeAuthor
#15 lingotek-entity-display-mapper-support-3055459-15.patch105.7 KBalex.bukach
#13 3055459-entity-display-mapper-support-13.patch105.62 KBpenyaskito
#13 3055459-entity-display-mapper-support.interdiff.12-13.txt2.45 KBpenyaskito
#12 3055459-entity-display-mapper-support-12.patch105.65 KBpenyaskito
#11 3055459-entity-display-mapper-support-11.patch105.72 KBpenyaskito
#11 3055459-entity-display-mapper-support.interdiff.8-11.txt96.47 KBpenyaskito
#8 3055459-entity-display-mapper-support-8.patch11.14 KBpenyaskito
#2 3055459-entity-display-mapper-support-2.patch11.11 KBpenyaskito

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3055459-entity-display-mapper-support-2.patch11.11 KB

Added patch.

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented

The above patch plus the patch found here
https://www.drupal.org/project/drupal/issues/2546212

Resolve the issue posted here
https://www.drupal.org/project/lingotek/issues/3052634#comment-13110971

I was able to round trip the placeholder text to Lingotek for translation. RTBC +1

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Title: Translation support for EntityViewDisplay/EntityFormDisplay translations » Translation support for entity view/form mode formatter/widget settings
Related issues: +#2546212: Entity view/form mode formatter/widget settings have no translation UI
johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented

Looks like I may have spoke to soon

I'm seeing a new error when trying to download translations.

Uncaught PHP Exception Symfony\\Component\\Routing\\Exception\\MissingMandatoryParametersException: "Some mandatory parameters are missing ("form_mode_name") to generate a URL for route "entity.entity_form_display.config_translation_overview.commerce_product_attribute_value"." at /app/docroot/core/lib/Drupal/Core/Routing/UrlGenerator.php line 182

I also have the config read only module enabled. not sure if that is also causing an issue here.

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented
Status: Needs review » Reviewed & tested by the community

The above issue does not appear to be related to this. Once I configured the Config Read Only whitelist correctly the module/patch worked as designed.

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented
Status: Reviewed & tested by the community » Needs work

This patch needs to be re-rolled for the latest version of the module.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 3055459-entity-display-mapper-support-8.patch11.14 KB

Rerolled. Untested, but should work as the change was trivial.
This won't land until #2546212: Entity view/form mode formatter/widget settings have no translation UI is committed, and we are still lacking unit tests. Sorry for the annoyances.

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented

I can confirm that the path in #8 works with Drupal 8.7.7 and Lingotek 2.14. RTBC +1

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Related issues: +#3099612: EntityFormDisplay and EntityViewDisplay should implement label()
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new 3055459-entity-display-mapper-support.interdiff.8-11.txt96.47 KB
new 3055459-entity-display-mapper-support-11.patch105.72 KB

WIP. Added some tests (still more missing, specially for view displays) with the patch.
Fixed tracking of edits/creation and checking the configured profile for display/form display.

These probably won't pass as the testbot won't have the required core patch, but this is safe (even safer now) to use.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Version: 8.x-2.x-dev » 3.4.x-dev
StatusFileSize
new 3055459-entity-display-mapper-support-12.patch105.65 KB

Rerolled.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new 3055459-entity-display-mapper-support.interdiff.12-13.txt2.45 KB
new 3055459-entity-display-mapper-support-13.patch105.62 KB

Fix problems with ::setup() signature in new tests.
Fixed minor code standards.

Status: Needs review » Needs work

The last submitted patch, 13: 3055459-entity-display-mapper-support-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

alex.bukach’s picture

alex.bukach commented
Version: 3.4.x-dev » 4.1.x-dev
Status: Needs work » Needs review
StatusFileSize
new lingotek-entity-display-mapper-support-3055459-15.patch105.7 KB

Rerolled #13 against 4.1.x.