Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
#2546212: Entity view/form mode formatter/widget settings have no translation UI adds a new ConfigMapper type. We need to add support to that one so they can be translated with Lingotek.
Proposed resolution
Add support for EntityDisplayMapper.
Remaining tasks
TBD
User interface changes
TBD
API changes
TBD
Data model changes
TBD
Release notes snippet
TBD
Comment | File | Size | Author |
---|---|---|---|
#15 | lingotek-entity-display-mapper-support-3055459-15.patch | 105.7 KB | Alex Bukach |
#13 | 3055459-entity-display-mapper-support-13.patch | 105.62 KB | penyaskito |
Comments
Comment #2
penyaskitoAdded patch.
Comment #3
johnpicozziThe above patch plus the patch found here
https://www.drupal.org/project/drupal/issues/2546212
Resolve the issue posted here
https://www.drupal.org/project/lingotek/issues/3052634#comment-13110971
I was able to round trip the placeholder text to Lingotek for translation. RTBC +1
Comment #4
penyaskitoComment #5
johnpicozziLooks like I may have spoke to soon
I'm seeing a new error when trying to download translations.
Uncaught PHP Exception Symfony\\Component\\Routing\\Exception\\MissingMandatoryParametersException: "Some mandatory parameters are missing ("form_mode_name") to generate a URL for route "entity.entity_form_display.config_translation_overview.commerce_product_attribute_value"." at /app/docroot/core/lib/Drupal/Core/Routing/UrlGenerator.php line 182
I also have the config read only module enabled. not sure if that is also causing an issue here.
Comment #6
johnpicozziThe above issue does not appear to be related to this. Once I configured the Config Read Only whitelist correctly the module/patch worked as designed.
Comment #7
johnpicozziThis patch needs to be re-rolled for the latest version of the module.
Comment #8
penyaskitoRerolled. Untested, but should work as the change was trivial.
This won't land until #2546212: Entity view/form mode formatter/widget settings have no translation UI is committed, and we are still lacking unit tests. Sorry for the annoyances.
Comment #9
johnpicozziI can confirm that the path in #8 works with Drupal 8.7.7 and Lingotek 2.14. RTBC +1
Comment #10
penyaskitoComment #11
penyaskitoWIP. Added some tests (still more missing, specially for view displays) with the patch.
Fixed tracking of edits/creation and checking the configured profile for display/form display.
These probably won't pass as the testbot won't have the required core patch, but this is safe (even safer now) to use.
Comment #12
penyaskitoRerolled.
Comment #13
penyaskitoFix problems with
::setup()
signature in new tests.Fixed minor code standards.
Comment #15
Alex Bukach CreditAttribution: Alex Bukach at Oomph, Inc. commentedRerolled #13 against 4.1.x.