Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

Status: Active » Needs review
FileSize
11.11 KB

Added patch.

johnpicozzi’s picture

The above patch plus the patch found here
https://www.drupal.org/project/drupal/issues/2546212

Resolve the issue posted here
https://www.drupal.org/project/lingotek/issues/3052634#comment-13110971

I was able to round trip the placeholder text to Lingotek for translation. RTBC +1

penyaskito’s picture

Title: Translation support for EntityViewDisplay/EntityFormDisplay translations » Translation support for entity view/form mode formatter/widget settings
Related issues: +#2546212: Entity view/form mode formatter/widget settings have no translation UI
johnpicozzi’s picture

Looks like I may have spoke to soon

I'm seeing a new error when trying to download translations.

Uncaught PHP Exception Symfony\\Component\\Routing\\Exception\\MissingMandatoryParametersException: "Some mandatory parameters are missing ("form_mode_name") to generate a URL for route "entity.entity_form_display.config_translation_overview.commerce_product_attribute_value"." at /app/docroot/core/lib/Drupal/Core/Routing/UrlGenerator.php line 182

I also have the config read only module enabled. not sure if that is also causing an issue here.

johnpicozzi’s picture

Status: Needs review » Reviewed & tested by the community

The above issue does not appear to be related to this. Once I configured the Config Read Only whitelist correctly the module/patch worked as designed.

johnpicozzi’s picture

Status: Reviewed & tested by the community » Needs work

This patch needs to be re-rolled for the latest version of the module.

penyaskito’s picture

Status: Needs work » Needs review
FileSize
11.14 KB

Rerolled. Untested, but should work as the change was trivial.
This won't land until #2546212: Entity view/form mode formatter/widget settings have no translation UI is committed, and we are still lacking unit tests. Sorry for the annoyances.

johnpicozzi’s picture

I can confirm that the path in #8 works with Drupal 8.7.7 and Lingotek 2.14. RTBC +1

penyaskito’s picture

penyaskito’s picture

WIP. Added some tests (still more missing, specially for view displays) with the patch.
Fixed tracking of edits/creation and checking the configured profile for display/form display.

These probably won't pass as the testbot won't have the required core patch, but this is safe (even safer now) to use.

penyaskito’s picture

Version: 8.x-2.x-dev » 3.4.x-dev
FileSize
105.65 KB

Rerolled.

penyaskito’s picture

Fix problems with ::setup() signature in new tests.
Fixed minor code standards.

Status: Needs review » Needs work

The last submitted patch, 13: 3055459-entity-display-mapper-support-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Alex Bukach’s picture

Version: 3.4.x-dev » 4.1.x-dev
Status: Needs work » Needs review
FileSize
105.7 KB

Rerolled #13 against 4.1.x.