Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Currently there are 6 update path tests in content moderation, however 5 out of the 6 are in the ./core/modules/content_moderation/tests/src/Functional
directory as opposed to the ./core/modules/content_moderation/tests/src/Functional/Update
directory.
Proposed resolution
Move the 5 tests that extend UpdatePathTestBase
into the Update
directory.
Remaining tasks
Move the tests and create a patch.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
None.
Comment | File | Size | Author |
---|---|---|---|
#19 | interdiff-3055075-16-19.txt | 5.67 KB | yogeshmpawar |
#19 | 3055075-19.patch | 8.47 KB | yogeshmpawar |
#16 | interdiff-3055075-13-16.txt | 4.93 KB | yogeshmpawar |
#16 | 3055075-16.patch | 7.23 KB | yogeshmpawar |
#13 | interdiff-3055075-9-13.txt | 3.51 KB | yogeshmpawar |
Comments
Comment #2
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext for Brisbane City Council commentedComment #3
TheSteveLavigne CreditAttribution: TheSteveLavigne commentedComment #4
TheSteveLavigne CreditAttribution: TheSteveLavigne commentedI am moving the tests and will create a patch.
Comment #5
TheSteveLavigne CreditAttribution: TheSteveLavigne at Portage CyberTech commentedThanks
Comment #6
TheSteveLavigne CreditAttribution: TheSteveLavigne commentedComment #7
TheSteveLavigne CreditAttribution: TheSteveLavigne commentedComment #8
TheSteveLavigne CreditAttribution: TheSteveLavigne commentedIt appears that my patch actually only removed the files, but did not add them back to the appropriate directory. Re-patching and pushing up.
Comment #9
TheSteveLavigne CreditAttribution: TheSteveLavigne commentedComment #11
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext for Brisbane City Council commentedHi @Nugg, thanks for picking up this issue! Something I neglected to mention was the namespace of each test will also need to change to reflect the new directory they are in.
Comment #12
yogeshmpawarComment #13
yogeshmpawarComments addressed in #11 & also added an interdiff.
Comment #15
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext for Brisbane City Council commentedLooks like the fixture paths also need an update.
Comment #16
yogeshmpawarUpdated patch will solve the test failures.
Comment #17
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext for Brisbane City Council commentedNice, looks good.
Comment #19
yogeshmpawarMissed a few instances of fixture paths, I have updated all instances now.
Comment #20
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext for Brisbane City Council commentedComment #21
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedComment #23
larowlanCommitted b165786 and pushed to 8.8.x. Thanks!
Comment #25
TheSteveLavigne CreditAttribution: TheSteveLavigne at Portage CyberTech commented