Problem/Motivation

Currently there are 6 update path tests in content moderation, however 5 out of the 6 are in the ./core/modules/content_moderation/tests/src/Functional directory as opposed to the ./core/modules/content_moderation/tests/src/Functional/Update directory.

Proposed resolution

Move the 5 tests that extend UpdatePathTestBase into the Update directory.

Remaining tasks

Move the tests and create a patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Issue summary: View changes
TheSteveLavigne’s picture

Assigned: Unassigned » TheSteveLavigne
TheSteveLavigne’s picture

I am moving the tests and will create a patch.

TheSteveLavigne’s picture

Status: Active » Needs review
FileSize
13.1 KB

Thanks

TheSteveLavigne’s picture

TheSteveLavigne’s picture

TheSteveLavigne’s picture

It appears that my patch actually only removed the files, but did not add them back to the appropriate directory. Re-patching and pushing up.

TheSteveLavigne’s picture

Status: Needs review » Needs work

The last submitted patch, 9: moved-test-to-update-directory-13127542-8.patch, failed testing. View results

Sam152’s picture

Hi @Nugg, thanks for picking up this issue! Something I neglected to mention was the namespace of each test will also need to change to reflect the new directory they are in.

yogeshmpawar’s picture

yogeshmpawar’s picture

Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
FileSize
4.64 KB
3.51 KB

Comments addressed in #11 & also added an interdiff.

Status: Needs review » Needs work

The last submitted patch, 13: 3055075-13.patch, failed testing. View results

Sam152’s picture

Looks like the fixture paths also need an update.

yogeshmpawar’s picture

Status: Needs work » Needs review
FileSize
7.23 KB
4.93 KB

Updated patch will solve the test failures.

Sam152’s picture

Status: Needs review » Reviewed & tested by the community

Nice, looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 16: 3055075-16.patch, failed testing. View results

yogeshmpawar’s picture

Status: Needs work » Needs review
FileSize
8.47 KB
5.67 KB

Missed a few instances of fixture paths, I have updated all instances now.

Sam152’s picture

Status: Needs review » Reviewed & tested by the community
Sam152’s picture

  • larowlan committed b165786 on 8.8.x
    Issue #3055075 by yogeshmpawar, Nugg, Sam152: Move update tests into the...
larowlan’s picture

Status: Reviewed & tested by the community » Fixed

Committed b165786 and pushed to 8.8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

TheSteveLavigne’s picture