Problem/Motivation

Currently there are 6 update path tests in content moderation, however 5 out of the 6 are in the ./core/modules/content_moderation/tests/src/Functional directory as opposed to the ./core/modules/content_moderation/tests/src/Functional/Update directory.

Proposed resolution

Move the 5 tests that extend UpdatePathTestBase into the Update directory.

Remaining tasks

Move the tests and create a patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#19 interdiff-3055075-16-19.txt5.67 KByogeshmpawar
#19 3055075-19.patch8.47 KByogeshmpawar
#16 interdiff-3055075-13-16.txt4.93 KByogeshmpawar
#16 3055075-16.patch7.23 KByogeshmpawar
#13 interdiff-3055075-9-13.txt3.51 KByogeshmpawar
#13 3055075-13.patch4.64 KByogeshmpawar
#9 moved-test-to-update-directory-13127542-8.patch2.26 KBthestevelavigne
#5 moved-test-to-update-directory-13127542-4.patch13.1 KBthestevelavigne

Comments

Sam152 created an issue. See original summary.

sam152’s picture

sam152 commented
Issue summary: View changes
thestevelavigne’s picture

thestevelavigne commented
Assigned: Unassigned » thestevelavigne
thestevelavigne’s picture

thestevelavigne commented

I am moving the tests and will create a patch.

thestevelavigne’s picture

thestevelavigne commented
Status: Active » Needs review
StatusFileSize
new moved-test-to-update-directory-13127542-4.patch13.1 KB

Thanks

thestevelavigne’s picture

thestevelavigne commented
thestevelavigne’s picture

thestevelavigne commented
thestevelavigne’s picture

thestevelavigne commented

It appears that my patch actually only removed the files, but did not add them back to the appropriate directory. Re-patching and pushing up.

thestevelavigne’s picture

thestevelavigne commented
StatusFileSize
new moved-test-to-update-directory-13127542-8.patch2.26 KB

Status: Needs review » Needs work

The last submitted patch, 9: moved-test-to-update-directory-13127542-8.patch, failed testing. View results

sam152’s picture

sam152 commented

Hi @Nugg, thanks for picking up this issue! Something I neglected to mention was the namespace of each test will also need to change to reflect the new directory they are in.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: thestevelavigne » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3055075-13.patch4.64 KB
new interdiff-3055075-9-13.txt3.51 KB

Comments addressed in #11 & also added an interdiff.

Status: Needs review » Needs work

The last submitted patch, 13: 3055075-13.patch, failed testing. View results

sam152’s picture

sam152 commented

Looks like the fixture paths also need an update.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs work » Needs review
StatusFileSize
new 3055075-16.patch7.23 KB
new interdiff-3055075-13-16.txt4.93 KB

Updated patch will solve the test failures.

sam152’s picture

sam152 commented
Status: Needs review » Reviewed & tested by the community

Nice, looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 16: 3055075-16.patch, failed testing. View results

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs work » Needs review
StatusFileSize
new 3055075-19.patch8.47 KB
new interdiff-3055075-16-19.txt5.67 KB

Missed a few instances of fixture paths, I have updated all instances now.

sam152’s picture

sam152 commented
Status: Needs review » Reviewed & tested by the community
sam152’s picture

sam152 commented

  • larowlan committed b165786 on 8.8.x 
    Issue #3055075 by yogeshmpawar, Nugg, Sam152: Move update tests into the...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed b165786 and pushed to 8.8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

thestevelavigne’s picture

thestevelavigne commented