I got the error when running this on the Emergency module: https://www.drupal.org/project/emergency

Invalid argument supplied for foreach() InfoToYAML.php:38

It's pretty obvious when looking at the code where the error occurred. If there are no dependencies, the foreach still attempts to access $info['dependencies'], which has not been set.

CommentFileSizeAuthor
#7 3055029-7.patch684 bytesjoshi.rohit100
#3 drupalmoduleupgrader-no-dependencies-3055029-3.patch2.28 KBsolideogloria
#2 drupalmoduleupgrader-no-dependencies-3055029-2.patch1.92 KBsolideogloria

Comments

solideogloria created an issue. See original summary.

solideogloria’s picture

solideogloria commented
Status: Active » Needs review
StatusFileSize
new drupalmoduleupgrader-no-dependencies-3055029-2.patch1.92 KB

I simply moved the loop inside the if statement

solideogloria’s picture

solideogloria commented
StatusFileSize
new drupalmoduleupgrader-no-dependencies-3055029-3.patch2.28 KB

Updated so that dependencies will be omitted from info.yml if there are none, rather than displaying empty curly braces.

The last submitted patch, 2: drupalmoduleupgrader-no-dependencies-3055029-2.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 3: drupalmoduleupgrader-no-dependencies-3055029-3.patch, failed testing. View results

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review

Changed back to Needs Review because branch is failing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
StatusFileSize
new 3055029-7.patch684 bytes

Uploading the fresh patch.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

This patch still applies cleanly
triggering test for php 7.1.x and core 8.7.x.
Ignore the php 5.x fails,

I have not confirmed the reported issue but the patch makes sense.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.