https://github.com/algolia/autocomplete.js

CommentFileSizeAuthor
#12 interdiff-11-12.txt506 bytesswarad07
#12 3054878-12.patch89.2 KBswarad07
#11 3054878-11.patch89.24 KBnikunjkotecha
#11 interdiff-10-11.txt617 bytesnikunjkotecha
#10 interdiff-9-10.txt501 bytesnikunjkotecha
#10 3054878-10.patch89.22 KBnikunjkotecha
#9 interdiff-8-9.txt969 bytesnikunjkotecha
#9 3054878-9.patch89.11 KBnikunjkotecha
#8 3054878-8.patch88.8 KBnikunjkotecha
#8 interdiff-4-8.txt2.1 KBnikunjkotecha
#7 interdiff-4-6.txt2.12 KBnikunjkotecha
#7 3054878-6.patch88.82 KBnikunjkotecha
#5 interdiff-4-5.txt590 bytesnikunjkotecha
#5 3054878-5.patch87.79 KBnikunjkotecha
#4 3054878-4.patch88.06 KBnikunjkotecha
#3 3054878-3.patch87.09 KBnikunjkotecha
#2 3054878-2.patch85.19 KBnikunjkotecha

Comments

nikunjkotecha created an issue. See original summary.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
Status: Active » Needs review
StatusFileSize
new 3054878-2.patch85.19 KB
nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
StatusFileSize
new 3054878-3.patch87.09 KB

Updated architecture to support multilingual using option 1 from https://www.algolia.com/doc/guides/managing-results/optimize-search-resu...

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
StatusFileSize
new 3054878-4.patch88.06 KB

Added search button and more JS.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
StatusFileSize
new 3054878-5.patch87.79 KB
new interdiff-4-5.txt590 bytes

update: clicking on suggestion only populates input

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
StatusFileSize
new 3054878-6.patch88.82 KB
new interdiff-4-6.txt2.12 KB

Ignore #5

Updated JS to populate on click of arrow and submit on click of text. Behavior follows suggestion from Algolia team and Amazon app.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
StatusFileSize
new interdiff-4-8.txt2.1 KB
new 3054878-8.patch88.8 KB

Removed unwanted brackground added in patch 3054878-6.patch

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
StatusFileSize
new 3054878-9.patch89.11 KB
new interdiff-8-9.txt969 bytes

Keep the dropdown open even after selection (Algolia team feedback).

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
StatusFileSize
new 3054878-10.patch89.22 KB
new interdiff-9-10.txt501 bytes

Update the results based on new value when clicking on arrow.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
StatusFileSize
new interdiff-10-11.txt617 bytes
new 3054878-11.patch89.24 KB

Encode text before adding to url.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
StatusFileSize
new 3054878-12.patch89.2 KB
new interdiff-11-12.txt506 bytes

Fixes a Syntax error in the code, which causes the JS to not work in IE.

benjy’s picture

benjy commented

I personally think this should be a separate module, there is the autocomplete library, a lot of CSS and it's quite opinionated (blocks) on how people use this library, many people might not need this feature.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
Status: Needs review » Closed (won't fix)

Agreed.